From f91778d2c72778bbe0da0f618277a6a231fc4857 Mon Sep 17 00:00:00 2001 From: Sam Roberts Date: Thu, 26 Sep 2019 12:51:46 -0700 Subject: [PATCH] build: remove unused libatomic on ppc64, s390x MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The library is not necessary for ppc64 or s390x. It does no harm with some linkers, but devtoolset-6 creates runtime dependencies on all link libraries, even unused ones. Fixes: https://github.com/nodejs/node/issues/27377 Fixes: https://github.com/nodejs/node/issues/29718 PR-URL: https://github.com/nodejs/node/pull/29727 Reviewed-By: Michaƫl Zasso Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Ruben Bridgewater Reviewed-By: Michael Dawson Reviewed-By: James M Snell --- tools/v8_gypfiles/v8.gyp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp index 00e285ec2c2025..a506a67dba6d42 100644 --- a/tools/v8_gypfiles/v8.gyp +++ b/tools/v8_gypfiles/v8.gyp @@ -795,7 +795,7 @@ }], # Platforms that don't have Compare-And-Swap (CAS) support need to link atomic library # to implement atomic memory access - ['v8_current_cpu in ["mips", "mipsel", "mips64", "mips64el", "ppc", "ppc64", "s390x"]', { + ['v8_current_cpu in ["mips", "mipsel", "mips64", "mips64el", "ppc"]', { 'link_settings': { 'libraries': ['-latomic', ], },