Skip to content

Commit

Permalink
report: fix stderr matching for fatal error
Browse files Browse the repository at this point in the history
PR-URL: #32699
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
  • Loading branch information
gengjiawen authored and targos committed Apr 28, 2020
1 parent 6aa3869 commit f945a5e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/report/test-report-fatal-error.js
Expand Up @@ -113,8 +113,8 @@ const ARGS = [
assert.strictEqual(reports.length, 0);

const lines = child.stderr.split('\n');
// Skip over unavoidable free-form output from V8.
const report = lines[1];
// Skip over unavoidable free-form output and gc log from V8.
const report = lines.find((i) => i.startsWith('{'));
const json = JSON.parse(report);

assert.strictEqual(json.header.threadId, null);
Expand Down

0 comments on commit f945a5e

Please sign in to comment.