From fa1fa3111acbb43a78b1b6434d193a10b9ef9f5d Mon Sep 17 00:00:00 2001 From: Bradley Farias Date: Wed, 11 Mar 2020 11:01:14 -0500 Subject: [PATCH] util: text decoding allows SharedArrayBuffer PR-URL: https://github.com/nodejs/node/pull/32203 Fixes: https://github.com/nodejs/node/issues/32199 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Ruben Bridgewater Reviewed-By: Gus Caplan Reviewed-By: James M Snell Reviewed-By: Luigi Pinca --- lib/internal/encoding.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/internal/encoding.js b/lib/internal/encoding.js index 6cb840e9d1e84f..befc4f811b2dde 100644 --- a/lib/internal/encoding.js +++ b/lib/internal/encoding.js @@ -31,7 +31,7 @@ const { } = require('internal/util'); const { - isArrayBuffer, + isAnyArrayBuffer, isArrayBufferView, isUint8Array } = require('internal/util/types'); @@ -404,7 +404,7 @@ function makeTextDecoderICU() { decode(input = empty, options = {}) { validateDecoder(this); - if (isArrayBuffer(input)) { + if (isAnyArrayBuffer(input)) { input = lazyBuffer().from(input); } else if (!isArrayBufferView(input)) { throw new ERR_INVALID_ARG_TYPE('input', @@ -469,7 +469,7 @@ function makeTextDecoderJS() { decode(input = empty, options = {}) { validateDecoder(this); - if (isArrayBuffer(input)) { + if (isAnyArrayBuffer(input)) { input = lazyBuffer().from(input); } else if (isArrayBufferView(input)) { input = lazyBuffer().from(input.buffer, input.byteOffset,