Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move all the streams constructors to internal/streams and avoid a circular dependencies between the modules. See: nodejs/readable-stream#348 PR-URL: #35239 Backport-PR-URL: #35349 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
- Loading branch information
1 parent
d58a466
commit fb14acb
Showing
14 changed files
with
2,568 additions
and
2,536 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,108 +1,6 @@ | ||
| // Copyright Joyent, Inc. and other Node contributors. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a | ||
| // copy of this software and associated documentation files (the | ||
| // "Software"), to deal in the Software without restriction, including | ||
| // without limitation the rights to use, copy, modify, merge, publish, | ||
| // distribute, sublicense, and/or sell copies of the Software, and to permit | ||
| // persons to whom the Software is furnished to do so, subject to the | ||
| // following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included | ||
| // in all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS | ||
| // OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | ||
| // MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN | ||
| // NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
| // DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
| // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | ||
| // USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
|
||
| // a duplex stream is just a stream that is both readable and writable. | ||
| // Since JS doesn't have multiple prototype inheritance, this class | ||
| // prototypically inherits from Readable, and then parasitically from | ||
| // Writable. | ||
|
|
||
| 'use strict'; | ||
|
|
||
| const { | ||
| ObjectDefineProperties, | ||
| ObjectGetOwnPropertyDescriptor, | ||
| ObjectKeys, | ||
| ObjectSetPrototypeOf, | ||
| } = primordials; | ||
| // TODO(mcollina): deprecate this file | ||
|
|
||
| const Duplex = require('internal/streams/duplex'); | ||
| module.exports = Duplex; | ||
|
|
||
| const Readable = require('_stream_readable'); | ||
| const Writable = require('_stream_writable'); | ||
|
|
||
| ObjectSetPrototypeOf(Duplex.prototype, Readable.prototype); | ||
| ObjectSetPrototypeOf(Duplex, Readable); | ||
|
|
||
| { | ||
| // Allow the keys array to be GC'ed. | ||
| for (const method of ObjectKeys(Writable.prototype)) { | ||
| if (!Duplex.prototype[method]) | ||
| Duplex.prototype[method] = Writable.prototype[method]; | ||
| } | ||
| } | ||
|
|
||
| function Duplex(options) { | ||
| if (!(this instanceof Duplex)) | ||
| return new Duplex(options); | ||
|
|
||
| Readable.call(this, options); | ||
| Writable.call(this, options); | ||
| this.allowHalfOpen = true; | ||
|
|
||
| if (options) { | ||
| if (options.readable === false) | ||
| this.readable = false; | ||
|
|
||
| if (options.writable === false) | ||
| this.writable = false; | ||
|
|
||
| if (options.allowHalfOpen === false) { | ||
| this.allowHalfOpen = false; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| ObjectDefineProperties(Duplex.prototype, { | ||
| writable: | ||
| ObjectGetOwnPropertyDescriptor(Writable.prototype, 'writable'), | ||
| writableHighWaterMark: | ||
| ObjectGetOwnPropertyDescriptor(Writable.prototype, 'writableHighWaterMark'), | ||
| writableObjectMode: | ||
| ObjectGetOwnPropertyDescriptor(Writable.prototype, 'writableObjectMode'), | ||
| writableBuffer: | ||
| ObjectGetOwnPropertyDescriptor(Writable.prototype, 'writableBuffer'), | ||
| writableLength: | ||
| ObjectGetOwnPropertyDescriptor(Writable.prototype, 'writableLength'), | ||
| writableFinished: | ||
| ObjectGetOwnPropertyDescriptor(Writable.prototype, 'writableFinished'), | ||
| writableCorked: | ||
| ObjectGetOwnPropertyDescriptor(Writable.prototype, 'writableCorked'), | ||
| writableEnded: | ||
| ObjectGetOwnPropertyDescriptor(Writable.prototype, 'writableEnded'), | ||
|
|
||
| destroyed: { | ||
| get() { | ||
| if (this._readableState === undefined || | ||
| this._writableState === undefined) { | ||
| return false; | ||
| } | ||
| return this._readableState.destroyed && this._writableState.destroyed; | ||
| }, | ||
| set(value) { | ||
| // Backward compatibility, the user is explicitly | ||
| // managing destroyed. | ||
| if (this._readableState && this._writableState) { | ||
| this._readableState.destroyed = value; | ||
| this._writableState.destroyed = value; | ||
| } | ||
| } | ||
| } | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,47 +1,6 @@ | ||
| // Copyright Joyent, Inc. and other Node contributors. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a | ||
| // copy of this software and associated documentation files (the | ||
| // "Software"), to deal in the Software without restriction, including | ||
| // without limitation the rights to use, copy, modify, merge, publish, | ||
| // distribute, sublicense, and/or sell copies of the Software, and to permit | ||
| // persons to whom the Software is furnished to do so, subject to the | ||
| // following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included | ||
| // in all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS | ||
| // OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | ||
| // MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN | ||
| // NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
| // DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
| // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | ||
| // USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
|
||
| // a passthrough stream. | ||
| // basically just the most minimal sort of Transform stream. | ||
| // Every written chunk gets output as-is. | ||
|
|
||
| 'use strict'; | ||
|
|
||
| const { | ||
| ObjectSetPrototypeOf, | ||
| } = primordials; | ||
| // TODO(mcollina): deprecate this file | ||
|
|
||
| const PassThrough = require('internal/streams/passthrough'); | ||
| module.exports = PassThrough; | ||
|
|
||
| const Transform = require('_stream_transform'); | ||
| ObjectSetPrototypeOf(PassThrough.prototype, Transform.prototype); | ||
| ObjectSetPrototypeOf(PassThrough, Transform); | ||
|
|
||
| function PassThrough(options) { | ||
| if (!(this instanceof PassThrough)) | ||
| return new PassThrough(options); | ||
|
|
||
| Transform.call(this, options); | ||
| } | ||
|
|
||
| PassThrough.prototype._transform = function(chunk, encoding, cb) { | ||
| cb(null, chunk); | ||
| }; |
Oops, something went wrong.