From fbd6fe5839cb43637e7ec29df46a44c62417cf2b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 17 Jun 2020 06:25:40 -0700 Subject: [PATCH] doc: update code language flag for internal doc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use `bash` instead of `shell` for code language flag in doc/guides/maintaining-ngtcp2-nghttp3.md to conform with our other docs and upcoming lint requirements. PR-URL: https://github.com/nodejs/node/pull/33852 Reviewed-By: Michaël Zasso Reviewed-By: Daijiro Wachi --- tools/icu/README.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/icu/README.md b/tools/icu/README.md index 4ce7e4483fcf40..011ce1f24f7ca9 100644 --- a/tools/icu/README.md +++ b/tools/icu/README.md @@ -25,7 +25,7 @@ internationalization functionality. * Configure Node.js with the specific [ICU version](http://icu-project.org/download) you want to upgrade to, for example: -```shell +```bash ./configure \ --with-intl=small-icu \ --with-icu-source=http://download.icu-project.org/files/icu4c/58.1/icu4c-58_1-src.tgz @@ -42,7 +42,7 @@ make * Verify the Node.js build works: -```shell +```bash make test-ci ``` @@ -58,13 +58,13 @@ new Intl.DateTimeFormat('es', {month: 'long'}).format(new Date(9E8)); * Now, copy `deps/icu` over to `deps/icu-small` -```shell +```bash python tools/icu/shrink-icu-src.py ``` * Now, do a clean rebuild of Node.js to test: -```shell +```bash make -k distclean ./configure make @@ -86,7 +86,7 @@ so make this a separate commit from the smaller changes. * Now, rebuild the Node.js license. -```shell +```bash # clean up - remove deps/icu make clean tools/license-builder.sh @@ -96,7 +96,7 @@ tools/license-builder.sh It should match the ICU URL used in the first step. When this is done, the following should build with full ICU. -```shell +```bash # clean up rm -rf out deps/icu deps/icu4c* ./configure --with-intl=full-icu --download=all