Skip to content

Commit fcf3781

Browse files
juanarboldanielleadams
authored andcommittedJul 9, 2023
lib,src,test: lint codebase according new rules for v18.x
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #48697 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
1 parent 2262653 commit fcf3781

File tree

5 files changed

+5
-14
lines changed

5 files changed

+5
-14
lines changed
 

‎lib/internal/fs/promises.js

-8
Original file line numberDiff line numberDiff line change
@@ -110,14 +110,6 @@ const {
110110
JSTransferable, kDeserialize, kTransfer, kTransferList,
111111
} = require('internal/worker/js_transferable');
112112

113-
const {
114-
newReadableStreamFromStreamBase,
115-
} = require('internal/webstreams/adapters');
116-
117-
const {
118-
readableStreamCancel,
119-
} = require('internal/webstreams/readablestream');
120-
121113
const getDirectoryEntriesPromise = promisify(getDirents);
122114
const validateRmOptionsPromise = promisify(validateRmOptions);
123115

‎lib/internal/modules/esm/loader.js

-1
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,6 @@ class ESMLoader {
549549
* until it reaches the bottom or short-circuits.
550550
* @param {URL['href']} url The URL/path of the module to be loaded
551551
* @param {object} context Metadata about the module
552-
*
553552
* @returns {{ format: ModuleFormat, source: ModuleSource }}
554553
*/
555554
async load(url, context = {}) {

‎pyproject.toml

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ ignore = [
2828
"PLC1901",
2929
"RUF005",
3030
"RUF100",
31+
"RUF012",
3132
]
3233
line-length = 172
3334
target-version = "py37"

‎src/node_builtins.cc

+4-3
Original file line numberDiff line numberDiff line change
@@ -365,9 +365,10 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
365365
return scope.Escape(fun);
366366
}
367367

368-
MaybeLocal<Function> BuiltinLoader::LookupAndCompile(Local<Context> context,
369-
const char* id,
370-
Environment* optional_env) {
368+
MaybeLocal<Function> BuiltinLoader::LookupAndCompile(
369+
Local<Context> context,
370+
const char* id,
371+
Environment* optional_env) {
371372
Result result;
372373
std::vector<Local<String>> parameters;
373374
Isolate* isolate = context->GetIsolate();

‎test/common/wpt.js

-2
Original file line numberDiff line numberDiff line change
@@ -715,7 +715,6 @@ class WPTRunner {
715715
/**
716716
* Report the status of each specific test case (there could be multiple
717717
* in one test file).
718-
*
719718
* @param {string} filename
720719
* @param {Test} test The Test object returned by WPT harness
721720
*/
@@ -735,7 +734,6 @@ class WPTRunner {
735734

736735
/**
737736
* Report the status of each WPT test (one per file)
738-
*
739737
* @param {string} filename
740738
* @param {object} harnessStatus - The status object returned by WPT harness.
741739
*/

0 commit comments

Comments
 (0)