From fdda2ff53b51cae6223689ab61e0d7692f6a4d42 Mon Sep 17 00:00:00 2001 From: Aaron Friel Date: Tue, 13 Dec 2022 11:48:13 -0800 Subject: [PATCH] deps: V8: cherry-pick 30861a39323d MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Original commit message: [debug] Re-enable internal [[Scopes]] property We received feedback that the [[Scopes]] property has some legitimate use-cases not covered by the Scopes View during pause. We re-enable the feature for now and will remove the flag in a follow-up. R=bmeurer@chromium.org Bug: chromium:1365858 Change-Id: Ibf279ae6c4f5ae492d03e9b4ee7316f6500508d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4099385 Auto-Submit: Simon Zünd Commit-Queue: Benedikt Meurer Commit-Queue: Simon Zünd Reviewed-by: Benedikt Meurer Cr-Commit-Position: refs/heads/main@{#84800} Refs: https://github.com/v8/v8/commit/30861a39323d2d4263b2b9f5d9740134d4104cd3 PR-URL: https://github.com/nodejs/node/pull/45851 Reviewed-By: Yagiz Nizipli Reviewed-By: Michaël Zasso Reviewed-By: James M Snell --- deps/v8/src/flags/flag-definitions.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/v8/src/flags/flag-definitions.h b/deps/v8/src/flags/flag-definitions.h index c31a38930475db..eb3c7b1485fd40 100644 --- a/deps/v8/src/flags/flag-definitions.h +++ b/deps/v8/src/flags/flag-definitions.h @@ -1717,7 +1717,7 @@ DEFINE_BOOL(experimental_reuse_locals_blocklists, false, DEFINE_BOOL( live_edit_top_frame, true, "enable support for live-editing the top-most function on the stack") -DEFINE_BOOL(experimental_remove_internal_scopes_property, true, +DEFINE_BOOL(experimental_remove_internal_scopes_property, false, "don't report the artificial [[Scopes]] property for functions") // disassembler