From ff0b1000d1f6ff4fcfd78a901738a48b6fc0194a Mon Sep 17 00:00:00 2001 From: Phillip Johnsen Date: Fri, 11 Sep 2020 21:09:21 +0200 Subject: [PATCH] build: filter issues & PRs to auto close by matching on stalled label MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The auto closing of issues & PRs labelled with `stalled` doesn't seem to be working as expected. The GitHub Action UI gives the impression the stale action tries to execute more operations than it is allowed to do. Previously there was no filtering on issues & PRs. So when it tries to fetch all the currently open issues, checking whether or not they should be get closed, it would have to perform quite a few requests pagination requests to get the information needed. Knowing that we only care about issues & PRs already labelled `stalled`, we can provide the [`only-labels`](https://github.com/actions/stale/blob/13b324e4b28a2708236aadb11361fa65af60d201/action.yml#L38) option to make sure we only fetch relevant issues. Refs https://github.com/nodejs/node/issues/35144 PR-URL: https://github.com/nodejs/node/pull/35159 Reviewed-By: Richard Lau Reviewed-By: Mary Marchini Reviewed-By: Michaël Zasso --- .github/workflows/close-stalled.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/close-stalled.yml b/.github/workflows/close-stalled.yml index 89861c6445263a..335a1eea471b70 100644 --- a/.github/workflows/close-stalled.yml +++ b/.github/workflows/close-stalled.yml @@ -15,6 +15,8 @@ jobs: stale-issue-label: stalled close-issue-message: Closing this because it has stalled. Feel free to reopen if this issue is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. close-pr-message: Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. + # used to filter issues to check whether or not should be closed, avoids hitting maximum operations allowed if needing to paginate through all open issues + only-labels: stalled # deactivates automatic removal of stalled label if issue gets any activity remove-stale-when-updated: false # deactivates automatic stale labelling as we prefer to do that manually