From ff212f44b719370c6935b455a1de4a7cd699c3be Mon Sep 17 00:00:00 2001
From: ZiJian Liu <Lxxyxzj@gmail.com>
Date: Tue, 22 Dec 2020 20:55:11 +0800
Subject: [PATCH] test: increase coverage for diagnostics_channel

1. test subscribe with invalid args
https://coverage.nodejs.org/coverage-21f2e8859dfbf09f/lib/diagnostics_channel.js.html#L27

2. test create channel with invalid args
https://coverage.nodejs.org/coverage-21f2e8859dfbf09f/lib/diagnostics_channel.js.html#L98

PR-URL: https://github.com/nodejs/node/pull/36602
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
---
 .../test-diagnostics-channel-object-channel-pub-sub.js      | 4 ++++
 test/parallel/test-diagnostics-channel-symbol-named.js      | 6 ++++++
 2 files changed, 10 insertions(+)

diff --git a/test/parallel/test-diagnostics-channel-object-channel-pub-sub.js b/test/parallel/test-diagnostics-channel-object-channel-pub-sub.js
index bae69b02415785..cbc5b4d2e9a953 100644
--- a/test/parallel/test-diagnostics-channel-object-channel-pub-sub.js
+++ b/test/parallel/test-diagnostics-channel-object-channel-pub-sub.js
@@ -37,3 +37,7 @@ channel.publish(input);
 // Should not publish after subscriber is unsubscribed
 channel.unsubscribe(subscriber);
 assert.ok(!channel.hasSubscribers);
+
+assert.throws(() => {
+  channel.subscribe(null);
+}, { code: 'ERR_INVALID_ARG_TYPE' });
diff --git a/test/parallel/test-diagnostics-channel-symbol-named.js b/test/parallel/test-diagnostics-channel-symbol-named.js
index b98c2a1ef3ec6c..96fe0fa53596e2 100644
--- a/test/parallel/test-diagnostics-channel-symbol-named.js
+++ b/test/parallel/test-diagnostics-channel-symbol-named.js
@@ -20,3 +20,9 @@ channel.subscribe(common.mustCall((message, name) => {
 }));
 
 channel.publish(input);
+
+{
+  assert.throws(() => {
+    dc.channel(null);
+  }, /ERR_INVALID_ARG_TYPE/);
+}