Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backporting-to-release-lines.md? #19491

Closed
prog1dev opened this issue Mar 20, 2018 · 3 comments
Closed

Update backporting-to-release-lines.md? #19491

prog1dev opened this issue Mar 20, 2018 · 3 comments
Assignees

Comments

@prog1dev
Copy link
Contributor

prog1dev commented Mar 20, 2018

Should there be info about why particular pull request should be backported or not? And in which branches?

Or maybe not in backporting-to-release-lines.md but somewhere else?

Ref #18357 (comment)

@trivikr
Copy link
Member

trivikr commented Mar 25, 2018

cc @MylesBorins @nodejs/backporting

@gibfahn
Copy link
Member

gibfahn commented Mar 26, 2018

I think adding a couple of lines in the What should be backported makes sense.

What should be backported is basically "anything that a release team member wanted to backport but had merge conflicts when it was cherry-picked to a release line".

@gibfahn gibfahn self-assigned this Mar 26, 2018
@apapirovski
Copy link
Member

Going to close this out given the lack of movement. Feel free to reopen if you believe this is important but in that case... maybe consider a PR instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants