Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky addons/callback-scope/test-resolve-async #22668

Closed
lundibundi opened this issue Sep 2, 2018 · 1 comment
Closed

Flaky addons/callback-scope/test-resolve-async #22668

lundibundi opened this issue Sep 2, 2018 · 1 comment
Labels
addons Issues and PRs related to native addons. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Comments

@lundibundi
Copy link
Member

https://ci.nodejs.org/job/node-test-commit-linux/21264/nodes=fedora-latest-x64/testReport/junit/(root)/test/addons_callback_scope_test_resolve_async/

in #21596

  • Platform: fedora-latest-x64 (CI)
Error Message

assert.js:338
    throw err;
    ^

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert(called)

    at Timeout.setTimeout [as _onTimeout] (/home/iojs/build/workspace/node-test-commit-linux/nodes/fedora-latest-x64/test/addons/callback-scope/test-resolve-async.js:10:20)
    at ontimeout (timers.js:454:11)
    at tryOnTimeout (timers.js:326:5)
    at listOnTimeout (timers.js:300:5)
    at processTimers (timers.js:257:5)
@lundibundi lundibundi added test Issues and PRs related to the tests. addons Issues and PRs related to native addons. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Sep 2, 2018
@addaleax
Copy link
Member

addaleax commented Sep 2, 2018

See #22664 :)

addaleax added a commit to addaleax/node that referenced this issue Sep 3, 2018
@addaleax
test: fix flaky addons/callback-scope/test-resolve-async
b85baf7 
Fixes: nodejs#22668
@danbev danbev closed this as completed in 4a5886c Sep 7, 2018
targos pushed a commit that referenced this issue Sep 7, 2018
@addaleax @targos
test: fix flaky addons/callback-scope/test-resolve-async
1ce9416 
Fixes: #22668
PR-URL: #22664
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@addaleax @lundibundi