Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis linter false-negatives for commit message checks #23737

Closed
mmarchini opened this issue Oct 18, 2018 · 3 comments · Fixed by #23739
Closed

Travis linter false-negatives for commit message checks #23737

mmarchini opened this issue Oct 18, 2018 · 3 comments · Fixed by #23739
Labels
build Issues and PRs related to build files or the CI. flaky-test Issues and PRs related to the tests with unstable failures on the CI. meta Issues and PRs related to the general management of the project. test Issues and PRs related to the tests.

Comments

@mmarchini
Copy link
Contributor

Saw this on two PRs today (#23512 and #22079), Travis is complaining that "subsystem is missing". In both cases commit message is following our guidelines and have a valid subsystem in their titles.
@mmarchini mmarchini added the build Issues and PRs related to build files or the CI. label Oct 18, 2018
@richardlau
Copy link
Member

#23725

@refack refack mentioned this issue Oct 18, 2018
Merged
3 tasks
@refack
Copy link
Contributor

refack commented Oct 18, 2018

Opened #23739 to stop linting...

@refack refack added test Issues and PRs related to the tests. meta Issues and PRs related to the general management of the project. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Oct 18, 2018
@richardlau
Copy link
Member

The original issue is that Travis was misidentifying the commits for a PR.

Rather than rely on Travis to work out which commits should be linted, #24030, #24076, #24093 changed the Travis linter to use GitHub's API to query for commits for the PR being tested so should now be consistent with the list of commits for a PR in the GitHub web UI.

refack added a commit to refack/node that referenced this issue Nov 6, 2018
@refack
build,meta: don't fail Travis for commit message
bec505b 
PR-URL: nodejs#23739
Fixes: nodejs#23737
Refs: nodejs#22452
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
targos pushed a commit that referenced this issue Nov 6, 2018
@refack @targos
build,meta: don't fail Travis for commit message
26c1988 
PR-URL: #23739
Fixes: #23737
Refs: #22452
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this issue Nov 15, 2018
@refack @kiyomizumia
build,meta: don't fail Travis for commit message
b28788c 
PR-URL: nodejs#23739
Fixes: nodejs#23737
Refs: nodejs#22452
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
codebytere pushed a commit that referenced this issue Nov 29, 2018
@refack @codebytere
build,meta: don't fail Travis for commit message
fdfec16 
PR-URL: #23739
Fixes: #23737
Refs: #22452
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
MylesBorins pushed a commit that referenced this issue Nov 29, 2018
@refack @MylesBorins
build,meta: don't fail Travis for commit message
61458c4 
PR-URL: #23739
Fixes: #23737
Refs: #22452
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
MylesBorins pushed a commit that referenced this issue Dec 3, 2018
@refack @MylesBorins
build,meta: don't fail Travis for commit message
83b8c1f 
PR-URL: #23739
Fixes: #23737
Refs: #22452
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. flaky-test Issues and PRs related to the tests with unstable failures on the CI. meta Issues and PRs related to the general management of the project. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build,meta: don't fail Travis for commit message refack/node
3 participants
@refack @mmarchini @richardlau