New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: destroy with callback #29180

Closed

5 tasks

ronag opened this issue Aug 17, 2019 · 1 comment

Labels

stream

Member

ronag commented Aug 17, 2019 •

edited

We have an undocumented internal API on destroy with the a second callback argument. In some cases it is possibly not required or incorrectly used.

avoid in async iterator (stream: async iterator destroy compat #29176)
avoid in net (net: use callback to properly propagate error #29178)
avoid in stream base (stream: use callback to properly propagate error #29179)
avoid or make monkey patch safe in fs streams
avoid in http2

The text was updated successfully, but these errors were encountered:

ronag mentioned this issue

stream: async iterator destroy compat #29176

Closed

4 tasks

Fishrock123 added the stream label

Member Author

ronag commented Aug 24, 2019

moved to meta document

ronag closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment