Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node 12's libuv to 1.34.1 or 1.34.2 #31623

Closed
dhritzkiv opened this issue Feb 3, 2020 · 2 comments
Closed

Update node 12's libuv to 1.34.1 or 1.34.2 #31623

dhritzkiv opened this issue Feb 3, 2020 · 2 comments
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding. lts Issues and PRs related to Long Term Support releases. macos Issues and PRs related to the macOS platform / OSX.

Comments

@dhritzkiv
Copy link
Contributor

dhritzkiv commented Feb 3, 2020

Is your feature request related to a problem? Please describe.
Since 12.13.1, the bundled version of libuv has negatively altered the behaviour of certain node programs when running on macOS. Specifically, querying the display's pixel dimensions breaks due to the intricacies in TTY/process daemonization implementation on macOS. This has prevented headless-gl, among other graphical libraries/code from functioning at all.

The aforementioned libraries/code work in node <= 12.13.0, but not in 12.13.1 through to 13.6.0. This has since been fixed in node 13.7.0 with the inclusion of libuv 1.34.1, so only the 12.x line is in need of an update.

See libuv/libuv#2566 and libuv/libuv#2568 and #31328

Describe the solution you'd like
To back port the libuv update to nodejs 12.

Describe alternatives you've considered
Unfortunately, there are no workarounds to the problem in user land.

@richardlau
Copy link
Member

@nodejs/lts libuv 1.34.1 (#31332) went out in 13.7.0 (#31382) so will have been in current for two weeks by the time the release proposal for the next 12.x semver minor (12.15.0 (to be renumbered), #31368) is resumed after the security releases tomorrow. I have no objections to pull in the libuv upgrade in the next 12.x semver minor.

cc @targos

@richardlau richardlau added libuv Issues and PRs related to the libuv dependency or the uv binding. lts Issues and PRs related to Long Term Support releases. macos Issues and PRs related to the macOS platform / OSX. labels Feb 3, 2020
@s1hofmann
Copy link

Our CI system picked up node v12.16.2 and all issues have been resolved.

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding. lts Issues and PRs related to Long Term Support releases. macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
Development

No branches or pull requests

4 participants