Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: --max-old-space-size should be documented #32252

Closed
addaleax opened this issue Mar 13, 2020 · 7 comments
Closed

doc: --max-old-space-size should be documented #32252

addaleax opened this issue Mar 13, 2020 · 7 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@addaleax
Copy link
Member

Even though --max-old-space-size is a V8 flag, I would expect us to document it, given that it’s probably the most useful V8 flag for Node.js users overall.

Refs: #32251

@addaleax addaleax added doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. labels Mar 13, 2020
@jasnell
Copy link
Member

jasnell commented Mar 13, 2020

+1 ... Let's just make sure that v8 flags that are documented are separated off in their own section of cli.md with clear indication in the docs that they fall outside Node.js' responsibility and therefore cannot be covered by the semver rules. Beyond that, I'm very much +1 on documenting useful v8 options.

Obviously, we should get @nodejs/v8 folks to review those first tho ;-)

@nimit95
Copy link
Contributor

nimit95 commented Mar 13, 2020

If this is a good first issue, I would like to work on it. :)

@jasnell
Copy link
Member

jasnell commented Mar 13, 2020

@nimit95 ... definitely a good first issue. It would be good to include some explanation around best practices in use, at least in the cli.md doc part.

@nimit95
Copy link
Contributor

nimit95 commented Mar 13, 2020

Will make a PR and submit.

nimit95 added a commit to nimit95/node that referenced this issue Mar 14, 2020
This adds new section for v8 options and --max-old-space-size
Fixes: nodejs#32252
nimit95 added a commit to nimit95/node that referenced this issue Mar 14, 2020
Fixed a typo addition in doc/cli.md
Fixes: nodejs#32252
@juanarbol
Copy link
Member

@nimit95 You already made the changes, great! It would nice if you open the PR now.

targos pushed a commit that referenced this issue Apr 13, 2020
This adds new section for v8 options and --max-old-space-size
Fixes: #32252

PR-URL: #32262
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit that referenced this issue Apr 14, 2020
This adds new section for v8 options and --max-old-space-size
Fixes: #32252

PR-URL: #32262
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this issue Apr 22, 2020
This adds new section for v8 options and --max-old-space-size
Fixes: #32252

PR-URL: #32262
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@sideburnie
Copy link

sideburnie commented Jan 29, 2021

I'm not sure this is the right place to go, but is there any documentation of the maximum size of max-old-space-size (or the max heap size V8 will allow)?

On a machine with 256GB of ram another with 768GB of ram with a max-old-space-size of 200gb and 500gb with v14.15.1, I'm not seeing a heap larger than about 16GB regardless of max-old-space-size. Calling v8.getHeapStatistics() shows a heap_size_limit that matches my given max-old-space-size but total_heap_size never goes above above 16GB. I've tried with optimize-for-size and without.

I'm now finding that an older version that I had been using, v10.16.0, appears to use at least 32GB... still experimenting... but if there's a doc somewhere that specifies the actual max heap allowed (maybe by version?) I would definitely read it! TIA!

[edit]: well it looks like v10.16.0 crashes at about 33GB with a 500GB max-old-space-size...

@chenrulongmaster
Copy link

chenrulongmaster commented Jul 21, 2021

I'm not sure this is the right place to go, but is there any documentation of the maximum size of max-old-space-size (or the max heap size V8 will allow)?

On a machine with 256GB of ram another with 768GB of ram with a max-old-space-size of 200gb and 500gb with v14.15.1, I'm not seeing a heap larger than about 16GB regardless of max-old-space-size. Calling v8.getHeapStatistics() shows a heap_size_limit that matches my given max-old-space-size but total_heap_size never goes above above 16GB. I've tried with optimize-for-size and without.

I'm now finding that an older version that I had been using, v10.16.0, appears to use at least 32GB... still experimenting... but if there's a doc somewhere that specifies the actual max heap allowed (maybe by version?) I would definitely read it! TIA!

[edit]: well it looks like v10.16.0 crashes at about 33GB with a 500GB max-old-space-size...

I am also facing this issue, I want to build a very large object, and I have 256GB physical memory. But always failed, even I set max-old-space-size already. I am using v12.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Development

No branches or pull requests

6 participants