Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receiving invalid scriptId values from node nightly #32824

Closed
Shenniey opened this issue Apr 13, 2020 · 3 comments
Closed

Receiving invalid scriptId values from node nightly #32824

Shenniey opened this issue Apr 13, 2020 · 3 comments
Labels
inspector Issues and PRs related to the V8 inspector protocol

Comments

@Shenniey
Copy link

Shenniey commented Apr 13, 2020

  • Version: v14.0.0-nightly2020040504b71848af
  • Platform: 64-bit Windows, Version 1909
  • Subsystem: n/a

I realize this is on the Node nightly, so bugs are to be expected, but I wanted to bring attention to a bug on the Inspector protocol that we found on our nightly testing.

What steps will reproduce the bug?

When running a basic JS script and attempting to debug using inspect protocol, we never receive scriptParsed events for some of Node's internal modules (e.g. internal/async_hooks.js). This is a problem because we will often receive pause notifications with script IDs for scripts that we have never received.

How often does it reproduce? Is there a required condition?

Can be reproduced consistently every time (using VSCode to debug).

What is the expected behavior?

Expected behavior is to receive valid script IDs from Node (meaning we shouldn't be getting script ID values that we never received from the scriptParsed event).

@mmarchini mmarchini added the inspector Issues and PRs related to the V8 inspector protocol label Apr 13, 2020
@mmarchini
Copy link
Contributor

cc @nodejs/inspector (also cc @joyeecheung as it might be related to snapshots)

@joyeecheung
Copy link
Member

This seems like a duplicate of #32648 which should be addressed by #32672 - can you try a nightly built sometime later than Apr. 8?

@Shenniey
Copy link
Author

Yep, that fixed it 😀 thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

No branches or pull requests

3 participants