Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stream._construct #33586

Open
1 of 5 tasks
ronag opened this issue May 27, 2020 · 5 comments
Open
1 of 5 tasks

Use stream._construct #33586

ronag opened this issue May 27, 2020 · 5 comments
Labels
meta Issues and PRs related to the general management of the project. stream Issues and PRs related to the stream subsystem.

Comments

@ronag
Copy link
Member

ronag commented May 27, 2020 •
edited

Since we have landed construct in streams we should try and update relevant parts of core where it makes sense to use this feature:

  • fs (was fixed as part of the construct PR)
  • net
  • http
  • http2
  • ...
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label May 27, 2020
@ronag
Copy link
Member Author

ronag commented May 27, 2020 •
edited

net is tricky because of .connect() which we agreed on not deprecating #33204. It has a similar role to _construct. Will give it some more thought and see if we can implement connect as _construct.

@rickyes
Copy link
Contributor

rickyes commented May 27, 2020

@ronag I've been working on http-related source code lately, maybe I'll try an update to stream._construct.

@ronag ronag added the meta Issues and PRs related to the general management of the project. label May 27, 2020
@antsmartian
Copy link
Contributor

antsmartian commented May 29, 2020 •
edited

@ronag It would be great, if we can add the fs actual PR (#29656) in the description. So that it helps others to know more about the actual implementation.

@ronag
Copy link
Member Author

ronag commented May 29, 2020

@antsmartian Good call. Updated.

@ronag
Copy link
Member Author

ronag commented Jun 27, 2020

The whole Socket.connect thing makes life very difficult... I wish we could somehow deprecate and remove it :(.

This was referenced Jan 25, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this issue Sep 27, 2022
Open
This was referenced Sep 27, 2022
Open
Open
@137717unity 137717unity mentioned this issue Sep 28, 2022
Open
@snyk-bot snyk-bot mentioned this issue Sep 28, 2022
Open
@ron-a20 ron-a20 mentioned this issue Sep 28, 2022
Open
This was referenced Sep 28, 2022
Open
Open
@137717unity 137717unity mentioned this issue Jun 23, 2023
Open
@molllyn1 molllyn1 mentioned this issue Jun 23, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this issue Jun 24, 2023
Open
@ron-a20 ron-a20 mentioned this issue Jun 24, 2023
Open
@wedataintelligence wedataintelligence mentioned this issue Jun 24, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this issue Nov 25, 2023
Open
@wedataintelligence wedataintelligence mentioned this issue Nov 28, 2023
Open
@baby636 baby636 mentioned this issue Dec 7, 2023
Open
This was referenced Dec 15, 2023
Open
Open
@baby636 baby636 mentioned this issue Jan 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@antsmartian @ronag @rickyes