Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeOwner looks like not working for wasi #35162

Closed
gengjiawen opened this issue Sep 12, 2020 · 8 comments
Closed

CodeOwner looks like not working for wasi #35162

gengjiawen opened this issue Sep 12, 2020 · 8 comments

Comments

@gengjiawen
Copy link
Member

@mmarchini CodeOwner looks like not working. Is this because wasi team should have write permission for
nodejs/node repo ?

Originally posted by @gengjiawen in #35104 (comment)

@gengjiawen
Copy link
Member Author

cc @Trott

@mmarchini
Copy link
Contributor

Not related to write permissions because we now have a custom bot to circumvent that.

@mmarchini
Copy link
Contributor

Looking at the issue the team was mentioned for reviewing. Do you mean the team was not added as a reviewer? In that case it needs write permissions, but we settled on using the mention comment approach instead otherwise the org will become unmaintained if we have too many subteams on the collaborators team.

@gengjiawen
Copy link
Member Author

Looking at the issue the team was mentioned for reviewing. Do you mean the team was not added as a reviewer?

Yeap.

@gengjiawen
Copy link
Member Author

Also, related files not showing ownership. Below is a showcase for quic.

image

@mmarchini
Copy link
Contributor

Right, as I said the decision was to not use GitHub's builtin codeowners feature because of how hard it makes GitHub org management. FWIW I'm -1 to adding wasi as a subteam of collaborators, and I think we should remove the teams that are today (quic, net, http2)

@Trott
Copy link
Member

Trott commented Sep 12, 2020

Right, as I said the decision was to not use GitHub's builtin codeowners feature because of how hard it makes GitHub org management. FWIW I'm -1 to adding wasi as a subteam of collaborators, and I think we should remove the teams that are today (quic, net, http2)

+1 to all of that. This is working as expected. We're doing the best we reasonably can within the limitations of the functionality of CODEOWNERS.

@gengjiawen
Copy link
Member Author

I will close it for now then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants