Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI setup for nodejs.org release notes #35530

Open
nschonni opened this issue Oct 6, 2020 · 5 comments
Open

CI setup for nodejs.org release notes #35530

nschonni opened this issue Oct 6, 2020 · 5 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@nschonni
Copy link
Member

nschonni commented Oct 6, 2020

Is your feature request related to a problem? Please describe.
Please describe the problem you are trying to solve.

Currently the blog post for new releases is a manual process as mentioned in https://github.com/nodejs/node/blob/b15ed6515323ec6cae2bde78feabf805c2fbb6b1/doc/guides/releases.md#17-create-a-blog-post

Describe the solution you'd like
Please describe the desired behavior.

When a new GitHub Release is created:

Alternate flow would include the release updated event to either update the existing PR or create a new PR if information is added.

Describe alternatives you've considered
Please describe alternative solutions or features you have considered.

Keep it manual, as this is a small activity

/cc @nodejs/releasers

@MylesBorins
Copy link
Member

@codebytere and I were just talking about what we could do to automate the creation of the Release. One challenge we might find would be that the tag is generally pushed before the release is promoted and the assets / signatures are ready.

@nschonni
Copy link
Member Author

nschonni commented Oct 6, 2020

So I think maybe limiting to the published release type would allow controlling that

@codebytere
Copy link
Member

One potential avenue here is firing off the blog post job via repository_dispatch hook and the new version when the assets are promoted as part of the release shell script - i'd be happy to throw together a quick prototype for that over on the website repo with a description of what the POST request would need to look like!

@nschonni
Copy link
Member Author

nschonni commented Oct 7, 2020

Whatever works best for you, since it's currently your manual process :)
You might want to take a look at nodejs/docker-node#1337 on how docker-node will be sending the PR cross repo. The same bot token could probably be used here.

@targos
Copy link
Member

targos commented Oct 7, 2020

The creation of the GitHub release sounds like a good event since it's the last step of the releaser's job. Everything should be ready at that point

@watilde watilde added the build Issues and PRs related to build files or the CI. label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

No branches or pull requests

5 participants