Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for node:‑prefixed imports of built‑in modules to require(…) #36098

Closed
ExE-Boss opened this issue Nov 12, 2020 · 0 comments · Fixed by #37246
Closed

Add support for node:‑prefixed imports of built‑in modules to require(…) #36098

ExE-Boss opened this issue Nov 12, 2020 · 0 comments · Fixed by #37246
Labels
util Issues and PRs related to the built-in util module.

Comments

@ExE-Boss
Copy link
Contributor

See the 2020‑10‑29 TSC Meeting notes, where it was decided that CommonJS should also support node:‑prefixed imports, so that any future built‑in modules (e.g.: diagnostics_channel) don’t risk possible ecosystem breakage.
@ExE-Boss ExE-Boss mentioned this issue Nov 12, 2020
Closed
@PoojaDurgad PoojaDurgad added the util Issues and PRs related to the built-in util module. label Nov 23, 2020
This was referenced Feb 1, 2021
Closed
Merged
ExE-Boss added a commit to ExE-Boss/node that referenced this issue Feb 6, 2021
@ExE-Boss
module: add support for require("node:…")
8615225 
Fixes: nodejs#36098
@ExE-Boss ExE-Boss mentioned this issue Feb 6, 2021
Merged
ExE-Boss added a commit to ExE-Boss/node that referenced this issue Feb 6, 2021
@ExE-Boss
module: add support for node:‑prefixed require(…) calls
4f61960 
Fixes: nodejs#36098
ExE-Boss added a commit to ExE-Boss/node that referenced this issue Feb 6, 2021
@ExE-Boss
module: add support for node:‑prefixed require(…) calls
98b9a8a 
Fixes: nodejs#36098
ExE-Boss added a commit to ExE-Boss/node that referenced this issue Feb 6, 2021
@ExE-Boss @RaisinTen
module: add support for node:‑prefixed require(…) calls
083a92d 
Fixes: nodejs#36098

Co-authored-by: Darshan Sen <raisinten@gmail.com>
ExE-Boss added a commit to ExE-Boss/node that referenced this issue Feb 8, 2021
@ExE-Boss @RaisinTen
module: add support for node:‑prefixed require(…) calls
f5cdabe 
Fixes: nodejs#36098

Co-authored-by: Darshan Sen <raisinten@gmail.com>
@ExE-Boss ExE-Boss mentioned this issue Feb 12, 2021
Merged
8 tasks
ExE-Boss added a commit to ExE-Boss/node that referenced this issue Mar 5, 2021
@ExE-Boss @aduh95
@guybedford @RaisinTen
module: add support for node:‑prefixed require(…) calls
1d8c8b7 
Fixes: nodejs#36098

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Guy Bedford <guybedford@gmail.com>
Co-authored-by: Darshan Sen <raisinten@gmail.com>
@aduh95 aduh95 closed this as completed in 069b5df Mar 19, 2021
targos pushed a commit to targos/node that referenced this issue Aug 8, 2021
@ExE-Boss @targos
module: add support for node:‑prefixed require(…) calls
1ed98e8 
Fixes: nodejs#36098

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Guy Bedford <guybedford@gmail.com>
Co-authored-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs#37246
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this issue Sep 1, 2021
@ExE-Boss @targos
module: add support for node:‑prefixed require(…) calls
f9f9389 
Fixes: #36098

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Guy Bedford <guybedford@gmail.com>
Co-authored-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #37246
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@mirror-kt mirror-kt mentioned this issue Apr 14, 2023
Open
@ExE-Boss ExE-Boss mentioned this issue Sep 16, 2023
Merged
This was referenced Mar 9, 2024
Closed
Merged
Yang-33 added a commit to line/line-bot-sdk-nodejs that referenced this issue Mar 11, 2024
@Yang-33
Add 'node:' prefix explicitly to import built-in modules (#746)
b1db79a 
Current Node.js v18 allows us to use `node:` prefix to import built-in
modules. line-bot-sdk-nodejs only supports Node.js version >= 18, this
won't affect normal line-bot-sdk-nodejs users.


ref: nodejs/node#36098,
https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#2021-09-28-version-14180-fermium-lts-targos
ref: https://nodejs.org/api/esm.html#node-imports

list:
https://github.com/sindresorhus/builtin-modules/blob/main/builtin-modules.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

module: add support for node:‑prefixed require(…) calls ExE-Boss/node
2 participants
@ExE-Boss @PoojaDurgad