Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lodash cloneDeep console v12.20.0 #37023

Closed
sjcoder-2021 opened this issue Jan 22, 2021 · 2 comments
Closed

lodash cloneDeep console v12.20.0 #37023

sjcoder-2021 opened this issue Jan 22, 2021 · 2 comments
Labels
console Issues and PRs related to the console subsystem.

Comments

@sjcoder-2021
Copy link

sjcoder-2021 commented Jan 22, 2021

  • Version: 12.20.0
  • Platform: OSX
  • Subsystem:

What steps will reproduce the bug?

The cloneDeep from lodash 4.17.20 works fine for console object on 12.19.0, 12.19.1 and broken from 12.20.0.

var _ = require('lodash');
console.log(_.cloneDeep(console));

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

{
  log: [Function: log],
  warn: [Function: warn],
  dir: [Function: dir],
  time: [Function: time],
  timeEnd: [Function: timeEnd],
  timeLog: [Function: timeLog],
  trace: [Function: trace],
  assert: [Function: assert],
  clear: [Function: clear],
  count: [Function: count],
  countReset: [Function: countReset],
  group: [Function: group],
  groupEnd: [Function: groupEnd],
  table: [Function: table],
  debug: [Function: debug],
  info: [Function: info],
  dirxml: [Function: dirxml],
  error: [Function: error],
  groupCollapsed: [Function: groupCollapsed],
  Console: [Function: Console],
  profile: [Function: profile],
  profileEnd: [Function: profileEnd],
  timeStamp: [Function: timeStamp],
  context: [Function: context]
}

What do you see instead?

{}

Additional information

@targos targos added the console Issues and PRs related to the console subsystem. label Jan 23, 2021
@targos
Copy link
Member

targos commented Jan 23, 2021

The only obvious change to the console subsystem in v12.20.0 is #35399

@BridgeAR
Copy link
Member

I just checked the code in lodash and it does not clone objects with toStringTags that it does not recognize. Thus, it seems like it's an issue with lodash, not Node.js (Node.js followed the spec with the change in v12.20.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Issues and PRs related to the console subsystem.
Projects
None yet
Development

No branches or pull requests

3 participants