Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #39008 still reproducible on 14.x branch, PR #39011 needs to be backported #39762

Closed
batrla opened this issue Aug 13, 2021 · 1 comment
Closed
Labels
test Issues and PRs related to the tests.

Comments

@batrla
Copy link
Contributor

batrla commented Aug 13, 2021

Version

v14.17.5

Platform

SunOS myhost 5.11 11.4.36.101.0 i86pc i386 i86pc non-virtualized

Subsystem

test

What steps will reproduce the bug?

This PR is missing on 14.x branch: #39011 and as result the issue #39008 is still reproducible on 14.x branch on machine without internet connection. See https://github.com/nodejs/node/blob/v14.x/test/parallel/test-https-agent-unref-socket.js, it still refers to http://example.com.

Running (g)make test reports TIMEOUT in parallel/test-https-agent-unref-socket:

=== release test-https-agent-unref-socket ===
Path: parallel/test-https-agent-unref-socket
Command: out/Release/node /builds/vbatrla/node-aug12/components/nodejs14/build/amd64/test/parallel/test-https-agent-unref-socket.js
--- TIMEOUT ---

How often does it reproduce? Is there a required condition?

reproduces always on machine without internet connection

What is the expected behavior?

test should pass

What do you see instead?

test times out

Additional information

No response

@Ayase-252 Ayase-252 added test Issues and PRs related to the tests. v14.x labels Aug 16, 2021
@richardlau
Copy link
Member

richardlau commented Nov 25, 2021

#39011 was included in 14.18.0: #39990.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

3 participants