Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator || #40699

Closed
essential-existence opened this issue Nov 2, 2021 · 2 comments
Closed

operator || #40699

essential-existence opened this issue Nov 2, 2021 · 2 comments
Labels
fs Issues and PRs related to the fs subsystem / file system.

Comments

@essential-existence
Copy link

essential-existence commented Nov 2, 2021 •
edited by Trott

node/lib/internal/fs/promises.js

Line 524 in d68dd62

position = bufferOrOptions.position || null;

If the value is "0", it is converted to "null", which causes the low-level read position of the file to be taken into account. I suggest:
position = bufferOrOptions.position ?? null;.

Operator || - this evil!
@tniessen tniessen added the fs Issues and PRs related to the fs subsystem / file system. label Nov 2, 2021
@Trott Trott added the invalid Issues and PRs that are invalid. label Nov 2, 2021
@Trott Trott closed this as completed Nov 2, 2021
@Trott Trott reopened this Nov 2, 2021
@Trott Trott removed the invalid Issues and PRs that are invalid. label Nov 2, 2021
@mihilmy
Copy link
Contributor

mihilmy commented Nov 3, 2021 •
edited

Duplicate of #40715
I have some more details with repros in #40715

@VoltrexKeyva VoltrexKeyva linked a pull request Nov 3, 2021 that will close this issue
Use nullish coalescing to respect zero positional reads #40716
Closed
@aduh95 aduh95 mentioned this issue Nov 4, 2021
Closed
@essential-existence
Copy link
Author

Duplicate of #40715 I have some more details with repros in #40715

I am glad that you soon noticed this error too.

@Trott Trott closed this as completed in 2037ee8 Nov 12, 2021
targos pushed a commit that referenced this issue Nov 21, 2021
@mihilmy @targos
fs: nullish coalescing to respect zero positional reads
a5a1691 
When the file read position is moved passing zero is
not respected and `null` is used instead. PR fixes the
issues by using nullish coalescing which will return
the rhs only when the lhs is `null` or `undefined`;
respecting the zero.

Fixes: #40715

PR-URL: #40716
Fixes: #40699
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@christian102094 christian102094 mentioned this issue Jan 17, 2022
Closed
richardlau pushed a commit that referenced this issue Jan 25, 2022
@mihilmy @richardlau
fs: nullish coalescing to respect zero positional reads
fc328f1 
When the file read position is moved passing zero is
not respected and `null` is used instead. PR fixes the
issues by using nullish coalescing which will return
the rhs only when the lhs is `null` or `undefined`;
respecting the zero.

Fixes: #40715

PR-URL: #40716
Fixes: #40699
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
danielleadams pushed a commit that referenced this issue Jan 30, 2022
@mihilmy @danielleadams
fs: nullish coalescing to respect zero positional reads
7e221ae 
When the file read position is moved passing zero is
not respected and `null` is used instead. PR fixes the
issues by using nullish coalescing which will return
the rhs only when the lhs is `null` or `undefined`;
respecting the zero.

Fixes: #40715

PR-URL: #40716
Fixes: #40699
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
danielleadams pushed a commit that referenced this issue Feb 1, 2022
@mihilmy @danielleadams
fs: nullish coalescing to respect zero positional reads
0377edc 
When the file read position is moved passing zero is
not respected and `null` is used instead. PR fixes the
issues by using nullish coalescing which will return
the rhs only when the lhs is `null` or `undefined`;
respecting the zero.

Fixes: #40715

PR-URL: #40716
Fixes: #40699
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use nullish coalescing to respect zero positional reads mihilmy/node
4 participants
@Trott @tniessen @mihilmy @essential-existence