Investigate flaky test - parallel/test-fs-rmdir-recursive

[mhdawson]

Test

parallel/test-fs-rmdir-recursive

Platform

Windows, arm/linux

Console output

Can't clean tmpdir: C:\workspace\node-test-binary-windows-js-suites\node\test\.tmp.236
Files blocking: [ 'rmdir-recursive-0', 'rmdir-recursive-4', 'rmdir-recursive-5' ]

assert.js:982
    throw newErr;
    ^

AssertionError [ERR_ASSERTION]: ifError got unwanted exception: ENOTEMPTY: directory not empty, rmdir 'C:\workspace\node-test-binary-windows-js-suites\node\test\.tmp.236\rmdir-recursive-0\d-3-2\d-2-2\d-1-2'
    at C:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:338:12
    at C:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:375:15
    at fs.js:179:23
    at CB (internal/fs/rimraf.js:59:5)
    at internal/fs/rimraf.js:151:18
    at CB (internal/fs/rimraf.js:59:5)
    at internal/fs/rimraf.js:151:18
    at CB (internal/fs/rimraf.js:59:5)
    at internal/fs/rimraf.js:151:18
    at CB (internal/fs/rimraf.js:59:5)
 {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: [Error: ENOTEMPTY: directory not empty, rmdir 'C:\workspace\node-test-binary-windows-js-suites\node\test\.tmp.236\rmdir-recursive-0\d-3-2\d-2-2\d-1-2'] {
    errno: -4051,
    code: 'ENOTEMPTY',
    syscall: 'rmdir',
    path: 'C:\\workspace\\node-test-binary-windows-js-suites\\node\\test\\.tmp.236\\rmdir-recursive-0\\d-3-2\\d-2-2\\d-1-2'
  },
  expected: null,
  operator: 'ifError'
}

Build links

From latest reliability report

9 (#41083, #41022, #40980, #40899, #36696, #41046, #41146, #41149, #41173)

Additional information

There are also 5 instances of parallel/test-fs-rm failing in the reliability report. Often but not always in the same run as test-fs-rmdir-recursive. Maybe the tests have similar timing issues?

[iansu]

@mhdawson did the fix @bcoe made in #41545 solve this problem?

[bcoe]

@iansu mentioned in our tooling meeting, I think it might be worth serializing the test-fs-rmdir-recursive cb tests, as it might make it easier to determine where exactly the failure is happening ... I also have a hunch this might make the problem go away, if the underlying problem is two many fs operations happening in parallel on Windows.

[marco-ippolito]

Seems to be no longer as flaky since 10-10-2023
Query: https://github.com/nodejs/reliability/issues?q=is%3Aissue+is%3Aopen+test-fs-rmdir-recursive+sort%3Acreated-desc