Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test - parallel/test-common-expect-warning #42029

Closed
richardlau opened this issue Feb 17, 2022 · 3 comments
Closed

Investigate flaky test - parallel/test-common-expect-warning #42029

richardlau opened this issue Feb 17, 2022 · 3 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@richardlau
Copy link
Member

Test

parallel/test-common-expect-warning

Platform

Linux

Console output

not ok 325 parallel/test-common-expect-warning
  ---
  duration_ms: 0.782
  severity: fail
  exitcode: 1
  stack: |-
    node:assert:1026
        throw err;
        ^
    
    AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Unexpected extra warning received/. Input:
    
    ''
    
        at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-arm/test/parallel/test-common-expect-warning.js:41:14)
        at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-arm/test/common/index.js:416:15)
        at ChildProcess.emit (node:events:527:28)
        at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: '',
      expected: /Unexpected extra warning received/,
      operator: 'match'
    }
    
    Node.js v18.0.0-pre
  ...

Build links

Additional information

According to https://github.com/nodejs/reliability/issues?page=2&q=is%3Aissue+is%3Aopen+%22parallel%2Ftest-common-expect-warning%22 this first showed up on 2022-01-04 -- the test was added on 2021-12-30 by 0465373 so this may have been inherently flaky from the start.

@richardlau richardlau added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Feb 17, 2022
@benjamingr
Copy link
Member

This can probably be solved by moving the file to mjs, doing toArray instead of .on('data' from the child to avoid truncation?

lpinca added a commit to lpinca/node that referenced this issue Feb 18, 2022
The subprocess might exit before the data is flushed. Run the assertion
after the `'end'` event is emitted.

Fixes: nodejs#42029
@lpinca
Copy link
Member

lpinca commented Mar 14, 2022

No failures in the last 7 days. It seems that #42046 reduced the flakiness.

@lpinca
Copy link
Member

lpinca commented Jul 23, 2022

No new failures in a long time. I'm closing this.

@lpinca lpinca closed this as completed Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Development

No branches or pull requests

3 participants