building master on macOS ARM64 fails

[JakobJingleheimer]

Version

master

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

$> git fetch upstream
$> git checkout upstream/master
$> make -j8

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

Undefined symbols for architecture arm64:
  "node::shadow_realm::HostCreateShadowRealmContextCallback(v8::Local<v8::Context>)", referenced from:
      node::SetIsolateMiscHandlers(v8::Isolate*, node::IsolateSettings const&) in libnode.a(libnode.environment.o)
ld: symbol(s) not found for architecture arm64

Additional information

A git bisect confirms the breakage was introduced in commit e86a638 from #42869

commit e86a6383054623e5168384a83d8cd6ebfe1fb584
[…]
Date:   Tue May 3 00:46:31 2022 +0800
src: add initial shadow realm support

Add initial shadow realm support behind an off-by-default flag
`--experimental-shadow-realm`.

(which makes sense)

[targos]

I don't have this issue. Maybe try to rerun the configure script?

[JakobJingleheimer]

I ran ./configure --ninja --node-builtin-modules-path $(pwd) already if that's what you mean.

But ugh: I switched branches and switched back, and it suddenly resolved itself and now I can't repro it. After your suggestion, I tried switching back and forth running the configure script and still no.

[dnalborczyk]

@JakobJingleheimer in some situations running make clean helps as well (removes build artifacts).

make clean
./configure
make -j4 test

[JakobJingleheimer]

Ow, good to know, thanks.

I'll close if I still can't repro tomorrow (bedtime now).

[himself65]

3 days went by, reopen if you still cannot build the project.
Closing

[JakobJingleheimer]

Sorry, sprained my wrist. Yes, it's still working and I can't repro anymore.