Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_server handles headersTimeout and requestTimeout checking wrong #43355

Closed
emilfihlman opened this issue Jun 9, 2022 · 0 comments · Fixed by #45778
Closed

http_server handles headersTimeout and requestTimeout checking wrong #43355

emilfihlman opened this issue Jun 9, 2022 · 0 comments · Fixed by #45778
Labels
http Issues or PRs related to the http subsystem.

Comments

@emilfihlman
Copy link

emilfihlman commented Jun 9, 2022 •
edited by VoltrexKeyva

Version

master

Platform

any

Subsystem

http

What steps will reproduce the bug?

Attempt to create http.createServer with options that include requestTimeout and headersTimeout that are set the same and > 0

How often does it reproduce? Is there a required condition?

When creating http server with requestTimeout and headersTimeout set appropriately.

What is the expected behavior?

http server creation should succeed

What do you see instead?

node:_http_server:389
    throw new codes.ERR_OUT_OF_RANGE('headersTimeout', '>= requestTimeout', headersTimeout);
    ^

RangeError [ERR_OUT_OF_RANGE]: The value of "headersTimeout" is out of range. It must be >= requestTimeout. Received 1000
    at new NodeError (node:internal/errors:377:5)
    at Server.storeHTTPOptions (node:_http_server:389:11)
    at new Server (node:_http_server:431:20)
    at Object.createServer (node:http:59:10)
    at main ...
  code: 'ERR_OUT_OF_RANGE'
}

Node.js v18.2.0

Additional information

#43354
@VoltrexKeyva VoltrexKeyva added the http Issues or PRs related to the http subsystem. label Jun 9, 2022
@aduh95 aduh95 mentioned this issue Jun 9, 2022
Closed
@ShogunPanda ShogunPanda mentioned this issue Dec 7, 2022
Merged
nodejs-github-bot pushed a commit that referenced this issue Dec 24, 2022
@ShogunPanda @lpinca
http: improved timeout defaults handling
77f4985 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #45778
Fixes: #43355
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Jan 1, 2023
@ShogunPanda @lpinca @targos
http: improved timeout defaults handling
5a334c5 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #45778
Fixes: #43355
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this issue Jan 4, 2023
@ShogunPanda @lpinca @RafaelGSS
http: improved timeout defaults handling
bf254f6 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #45778
Fixes: #43355
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this issue Jan 5, 2023
@ShogunPanda @lpinca @RafaelGSS
http: improved timeout defaults handling
7ea72ee 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #45778
Fixes: #43355
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol pushed a commit that referenced this issue Jan 26, 2023
@ShogunPanda @lpinca @juanarbol
http: improved timeout defaults handling
ac649a7 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #45778
Fixes: #43355
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol pushed a commit that referenced this issue Jan 31, 2023
@ShogunPanda @lpinca @juanarbol
http: improved timeout defaults handling
3c0c5e0 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #45778
Fixes: #43355
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
2 participants
@emilfihlman @VoltrexKeyva