Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTBFS with GCC 13 #43642

Closed
marxin opened this issue Jul 1, 2022 · 4 comments · Fixed by #44961
Closed

FTBFS with GCC 13 #43642

marxin opened this issue Jul 1, 2022 · 4 comments · Fixed by #44961
Labels
v8 engine Issues and PRs related to the V8 dependency.

Comments

@marxin
Copy link

marxin commented Jul 1, 2022

Version

No response

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

Building with GCC 13 (current master):

[   38s] In file included from ../deps/v8/src/base/macros.h:12,
[   38s]                  from ../deps/v8/src/libplatform/worker-thread.h:12,
[   38s]                  from ../deps/v8/src/libplatform/worker-thread.cc:5:
[   38s] ../deps/v8/src/base/logging.h: In function 'auto v8::base::detail::GetUnderlyingEnumTypeForPrinting(T)':
[   38s] ../deps/v8/src/base/logging.h:154:26: error: 'uint16_t' was not declared in this scope
[   38s]   154 |                          uint16_t> >;
[   38s]       |                          ^~~~~~~~
[   38s] ../deps/v8/src/base/logging.h:17:1: note: 'uint16_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
[   38s]    16 | #include "src/base/template-utils.h"
[   38s]   +++ |+#include <cstdint>
[   38s]    17 | 
[   38s] ../deps/v8/src/base/logging.h:154:34: error: template argument 3 is invalid
[   38s]   154 |                          uint16_t> >;
[   38s]       |                                  ^

as described here:
https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

Build fine.

Additional information

No response
@mscdex
Copy link
Contributor

mscdex commented Jul 1, 2022

Issues with upstream dependencies should be made on their respective issue trackers. V8's is here.

@marxin
Copy link
Author

marxin commented Jul 1, 2022

I see, I've just done that:
https://bugs.chromium.org/p/v8/issues/detail?id=13029

@richardlau richardlau added the v8 engine Issues and PRs related to the V8 dependency. label Jul 1, 2022
@xen0n
Copy link

xen0n commented Oct 10, 2022 •
edited

A fix is just merged at https://chromium-review.googlesource.com/c/v8/v8/+/3934140; we could integrate/backport right away.

@gengjiawen gengjiawen mentioned this issue Oct 11, 2022
Merged
@gengjiawen
Copy link
Member

#44961

nodejs-github-bot pushed a commit that referenced this issue Oct 14, 2022
@gengjiawen
deps: V8: cherry-pick c2792e58035f
0be1c57 
Original commit message:

    [base] Fix build with gcc-13

    See https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes.

    Also see Gentoo Linux bug report: https://bugs.gentoo.org/865981

    Change-Id: I421f396b02ba37e12ee70048ee33e034f8113566
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3934140
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: Simon Zünd <szuend@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83587}

Refs: v8/v8@c2792e5
PR-URL: #44961
Fixes: #43642
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@gengjiawen @danielleadams
deps: V8: cherry-pick c2792e58035f
1abb5e7 
Original commit message:

    [base] Fix build with gcc-13

    See https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes.

    Also see Gentoo Linux bug report: https://bugs.gentoo.org/865981

    Change-Id: I421f396b02ba37e12ee70048ee33e034f8113566
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3934140
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: Simon Zünd <szuend@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83587}

Refs: v8/v8@c2792e5
PR-URL: #44961
Fixes: #43642
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@gengjiawen @danielleadams
deps: V8: cherry-pick c2792e58035f
c119a9d 
Original commit message:

    [base] Fix build with gcc-13

    See https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes.

    Also see Gentoo Linux bug report: https://bugs.gentoo.org/865981

    Change-Id: I421f396b02ba37e12ee70048ee33e034f8113566
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3934140
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: Simon Zünd <szuend@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83587}

Refs: v8/v8@c2792e5
PR-URL: #44961
Fixes: #43642
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit that referenced this issue Jan 3, 2023
@gengjiawen @danielleadams
deps: V8: cherry-pick c2792e58035f
596e3a8 
Original commit message:

    [base] Fix build with gcc-13

    See https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes.

    Also see Gentoo Linux bug report: https://bugs.gentoo.org/865981

    Change-Id: I421f396b02ba37e12ee70048ee33e034f8113566
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3934140
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: Simon Zünd <szuend@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83587}

Refs: v8/v8@c2792e5
PR-URL: #44961
Fixes: #43642
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this issue Mar 27, 2023
@gengjiawen @BethGriggs
deps: V8: cherry-pick c2792e58035f
56cbc7f 
Original commit message:

    [base] Fix build with gcc-13

    See https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes.

    Also see Gentoo Linux bug report: https://bugs.gentoo.org/865981

    Change-Id: I421f396b02ba37e12ee70048ee33e034f8113566
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3934140
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: Simon Zünd <szuend@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83587}

Refs: v8/v8@c2792e5
PR-URL: #44961
Fixes: #43642
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: V8: cherry-pick c2792e58035f gengjiawen/node
5 participants
@mscdex @xen0n @marxin @gengjiawen @richardlau