Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server.closeIdleConnections break gc tests #43795

Closed
F3n67u opened this issue Jul 12, 2022 · 1 comment
Closed

Server.closeIdleConnections break gc tests #43795

F3n67u opened this issue Jul 12, 2022 · 1 comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@F3n67u
Copy link
Member

F3n67u commented Jul 12, 2022

Version

main

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

No response

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

#43522 break a lot of tests, especially the gc-related test.

This issue is opened for TypeError: Cannot read properties of null (reading 'destroy') error. Ref to #43641 (comment) for why this error happened.

The Console output:

done/collected/total: 93/0/804
done/collected/total: 322/93/804
done/collected/total: 415/322/804
done/collected/total: 664/349/804
done/collected/total: 737/415/804
done/collected/total: 804/664/804
done/collected/total: 804/737/804
done/collected/total: 804/804/804
node:_http_server:498
    connections[i].socket.destroy();
                          ^

TypeError: Cannot read properties of null (reading 'destroy')
    at Server.closeIdleConnections (node:_http_server:498:27)
    at Server.close (node:_http_server:481:8)
    at Immediate.status (/home/iojs/build/workspace/node-test-binary-armv7l/test/parallel/test-gc-http-client-timeout.js:66:14)
    at process.processImmediate (node:internal/timers:471:21)

Node.js v19.0.0-pre

Tests affected by TypeError: Cannot read properties of null (reading 'destroy') error:

  1. sequential/test-gc-http-client-timeout
  2. sequential/test-gc-http-client
  3. sequential/test-gc-http-client-onerror

The below list is compiled from nodejs/reliability#320

Additional information

No response

@MoLow MoLow added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jul 14, 2022
@F3n67u
Copy link
Member Author

F3n67u commented Jul 24, 2022

closed by #43949

@F3n67u F3n67u closed this as completed Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants