Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is maintaining-zlib document up-to-date? #44254

Closed
RafaelGSS opened this issue Aug 16, 2022 · 5 comments
Closed

Is maintaining-zlib document up-to-date? #44254

RafaelGSS opened this issue Aug 16, 2022 · 5 comments
Labels
doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem.

Comments

@RafaelGSS
Copy link
Member

Pretty soon we'll need to update the zlib version (see nodejs/security-wg#824). I've tried to update it locally following the maintaining-zlib document, but things get breaking (it seems arch issues -- I'm on Linux).

Is it up-to-date? If not, how can I update it?

cc: @targos @sam-github

@Trott
Copy link
Member

Trott commented Aug 16, 2022

@nodejs/zlib

@daeyeon daeyeon added doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem. labels Aug 17, 2022
@targos
Copy link
Member

targos commented Aug 17, 2022

AFAIK the document is up-to-date, it's just that upstream made a lot of changes to the build config and this line is all about it:

It may be necessary to update deps/zlib/zlib.gyp if any significant changes have occurred upstream.

There have been multiple attempts to update zlib without success so far (I think it's mostly a question of time and C/build knowledge): #33044, #41745, #42570, #42571

My branch for #41745 went quite far, but there were performance concerns which I'm unable to handle.

@RafaelGSS
Copy link
Member Author

Ok, thanks!

I'll look at it and work soon as I have time. I'll keep this issue posted, probably we would need to update the document as well.

@Neustradamus
Copy link

To follow this ticket :)

@lpinca
Copy link
Member

lpinca commented Nov 17, 2022

I'm closing this as #45387 landed. Please comment or reopen if needed.

@lpinca lpinca closed this as completed Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Development

No branches or pull requests

6 participants