Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test-watch-mode #44655

Closed
tniessen opened this issue Sep 15, 2022 · 1 comment · Fixed by #44621
Closed

Investigate flaky test-watch-mode #44655

tniessen opened this issue Sep 15, 2022 · 1 comment · Fixed by #44621
Labels
aix Issues and PRs related to the AIX platform. arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. linux Issues and PRs related to the Linux platform.

Comments

@tniessen
Copy link
Member

Test

test-watch-mode

Platform

AIX, Linux ARMv7, Linux x64

Console output

11:00:15 not ok 3018 parallel/test-watch-mode
11:00:15   ---
11:00:15   duration_ms: 8.779
11:00:15   severity: fail
11:00:15   exitcode: 1
11:00:15   stack: |-
11:00:15     TAP version 13
11:00:15     # Subtest: watch mode
11:00:15         # Subtest: should watch changes to a file - event loop ended
11:00:15         ok 1 - should watch changes to a file - event loop ended
11:00:15           ---
11:00:15           duration_ms: 343.076379
11:00:15           ...
11:00:15         # Subtest: should watch changes to a failing file
11:00:15         not ok 2 - should watch changes to a failing file
11:00:15           ---
11:00:15           duration_ms: 187.291755
11:00:15           failureType: 'testCodeFailure'
11:00:15           error: |-
11:00:15             Expected values to be strictly equal:
11:00:15             
11:00:15             1 !== 2
11:00:15             
11:00:15           code: 'ERR_ASSERTION'
11:00:15           stack: |-
11:00:15             Object.<anonymous> (file:///home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-watch-mode.mjs:96:12)
11:00:15             process.processTicksAndRejections (node:internal/process/task_queues:95:5)
11:00:15             async ItTest.run (node:internal/test_runner/test:487:9)
11:00:15             async Suite.processPendingSubtests (node:internal/test_runner/test:252:7)
11:00:15           ...
11:00:15         # Subtest: should not watch when running an non-existing file
11:00:15         ok 3 - should not watch when running an non-existing file
11:00:15           ---
11:00:15           duration_ms: 156.845233
11:00:15           ...
11:00:15         # Subtest: should watch when running an non-existing file - when specified under --watch-path
11:00:15         ok 4 - should watch when running an non-existing file - when specified under --watch-path # SKIP
11:00:15           ---
11:00:15           duration_ms: 0.248841
11:00:15           ...
11:00:15         # Subtest: should watch changes to a file - event loop blocked
11:00:15         ok 5 - should watch changes to a file - event loop blocked
11:00:15           ---
11:00:15           duration_ms: 1368.871923
11:00:15           ...
11:00:15         # Subtest: should watch changes to dependencies - cjs
11:00:15         ok 6 - should watch changes to dependencies - cjs
11:00:15           ---
11:00:15           duration_ms: 321.395694
11:00:15           ...
11:00:15         # Subtest: should watch changes to dependencies - esm
11:00:15         ok 7 - should watch changes to dependencies - esm
11:00:15           ---
11:00:15           duration_ms: 334.368724
11:00:15           ...
11:00:15         # Subtest: should restart multiple times
11:00:15         ok 8 - should restart multiple times
11:00:15           ---
11:00:15           duration_ms: 2445.701405
11:00:15           ...
11:00:15         # Subtest: should gracefully wait when restarting
11:00:15         ok 9 - should gracefully wait when restarting
11:00:15           ---
11:00:15           duration_ms: 2309.426334
11:00:15           ...
11:00:15         # Subtest: should pass arguments to file
11:00:15         ok 10 - should pass arguments to file
11:00:15           ---
11:00:15           duration_ms: 294.614825
11:00:15           ...
11:00:15         # Subtest: should not load --require modules in main process
11:00:15         ok 11 - should not load --require modules in main process
11:00:15           ---
11:00:15           duration_ms: 286.417371
11:00:15           ...
11:00:15         # Subtest: should not load --import modules in main process
11:00:15         ok 12 - should not load --import modules in main process
11:00:15           ---
11:00:15           duration_ms: 334.634557
11:00:15           ...
11:00:15         1..12
11:00:15     not ok 1 - watch mode
11:00:15       ---
11:00:15       duration_ms: 8391.267708
11:00:15       failureType: 'subtestsFailed'
11:00:15       error: '1 subtest failed'
11:00:15       code: 'ERR_TEST_FAILURE'
11:00:15       ...
11:00:15     1..1
11:00:15     # tests 1
11:00:15     # pass 0
11:00:15     # fail 1
11:00:15     # cancelled 0
11:00:15     # skipped 0
11:00:15     # todo 0
11:00:15     # duration_ms 8394.665535
11:00:15     (node:30879) ExperimentalWarning: The test runner is an experimental feature. This feature could change at any time
11:00:15     (Use `node --trace-warnings ...` to show where the warning was created)
11:00:15   ...

Build links

Additional information

Added in #44366.

@tniessen tniessen added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Sep 15, 2022
@github-actions github-actions bot added aix Issues and PRs related to the AIX platform. arm Issues and PRs related to the ARM platform. linux Issues and PRs related to the Linux platform. labels Sep 15, 2022
@MoLow MoLow closed this as completed in 96f0722 Sep 20, 2022
@tniessen
Copy link
Member Author

This was closed by #44621, but the test immediately failed under ASan after #44621 landed.

Maybe the platform or the cause of the issue changed, so I've opened a new issue to track the flaky test again: #44735

RafaelGSS pushed a commit that referenced this issue Sep 26, 2022
PR-URL: #44621
Fixes: #44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS pushed a commit that referenced this issue Sep 26, 2022
PR-URL: #44621
Fixes: #44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Sep 29, 2022
PR-URL: nodejs#44621
Backport-PR-URL: nodejs#44815
Fixes: nodejs#44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this issue Oct 2, 2022
PR-URL: #44621
Backport-PR-URL: #44815
Fixes: #44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Oct 3, 2022
PR-URL: nodejs#44621
Backport-PR-URL: https://github.com/nodejs/node/pull/TBD
Fixes: nodejs#44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Oct 3, 2022
PR-URL: nodejs#44621
Backport-PR-URL: nodejs#44877
Fixes: nodejs#44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Oct 12, 2022
PR-URL: nodejs#44621
Backport-PR-URL: nodejs#44877
Fixes: nodejs#44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Oct 12, 2022
PR-URL: nodejs#44621
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Oct 12, 2022
PR-URL: nodejs#44621
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Oct 12, 2022
PR-URL: nodejs#44621
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
richardlau pushed a commit that referenced this issue Nov 23, 2022
PR-URL: #44621
Backport-PR-URL: #44976
Fixes: #44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
PR-URL: nodejs/node#44621
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
PR-URL: nodejs/node#44621
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aix Issues and PRs related to the AIX platform. arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. linux Issues and PRs related to the Linux platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant