Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

response.writeEarlyHints should support all link properties #44843

Closed
anonrig opened this issue Sep 30, 2022 · 2 comments · Fixed by #44874
Closed

response.writeEarlyHints should support all link properties #44843

anonrig opened this issue Sep 30, 2022 · 2 comments · Fixed by #44874
Labels
feature request Issues that request new features to be added to Node.js. http Issues or PRs related to the http subsystem. http2 Issues or PRs related to the http2 subsystem.

Comments

@anonrig
Copy link
Member

anonrig commented Sep 30, 2022 •
edited

What is the problem this feature will solve?

response.writeEarlyHints currently supports only as, anchor and title.

Referencing #44820

What is the feature you are proposing to solve the problem?

To have a feature & stable link header setting through writeEarlyHints API.

What alternatives have you considered?

No response
@anonrig anonrig added the feature request Issues that request new features to be added to Node.js. label Sep 30, 2022
@Trott Trott added the http2 Issues or PRs related to the http2 subsystem. label Sep 30, 2022
@Trott
Copy link
Member

Trott commented Sep 30, 2022

@nodejs/http2

@mcollina mcollina added the http Issues or PRs related to the http subsystem. label Oct 1, 2022
@mcollina
Copy link
Member

mcollina commented Oct 1, 2022

cc @nodejs/http

@anonrig anonrig changed the title response.writeEarlyHints should support all style properties response.writeEarlyHints should support all link properties Oct 3, 2022
@anonrig anonrig mentioned this issue Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. http Issues or PRs related to the http subsystem. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

http,http2: support more attributes for early hint link anonrig/node
3 participants
@mcollina @Trott @anonrig