Windows build failure : error C2512: no appropriate default constructor available

[ssrdive]

Version

19.0.0-pre

Platform

Windows 10

Subsystem

build

What steps will reproduce the bug?

Build node 19.0.0-pre with MSVC 14.29.30133

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Successful build of node

What do you see instead?

C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\xutility(1810,19): error C2512: 'v8::internal::compiler::turboshaft::Graph::OperationIterator<const v8::internal::compiler::turboshaft::Operation,const
v8::internal::compiler::turboshaft::Graph>::OperationIterator': no appropriate default constructor available [D:\Users\shamals\Documents\code\node\tools\v8_gypfiles\v8_compiler.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\xutility(1810): message : see reference to function 'std::reverse_iterator<v8::internal::compiler::turboshaft::Graph::OperationIterator<const v8::intern
al::compiler::turboshaft::Operation,const v8::internal::compiler::turboshaft::Graph>>::reverse_iterator(void)' [D:\Users\shamals\Documents\code\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\Users\shamals\Documents\code\node\deps\v8\src\base\iterator.h(62): message : see reference to class template instantiation 'v8::base::iterator_range<ForwardIterator>' being compiled [D:\Users\shamals\Documents\code\node\tools\v8_gypfiles\v8_comp
iler.vcxproj]
          with
          [
              ForwardIterator=std::reverse_iterator<v8::internal::compiler::turboshaft::Graph::OperationIterator<const v8::internal::compiler::turboshaft::Operation,const v8::internal::compiler::turboshaft::Graph>>
          ]
D:\Users\shamals\Documents\code\node\deps\v8\src\base\iterator.h(105): message : see reference to function template instantiation 'auto v8::base::make_iterator_range<std::reverse_iterator<v8::internal::compiler::turboshaft::Graph::OperationIterator
<const v8::internal::compiler::turboshaft::Operation,const v8::internal::compiler::turboshaft::Graph>>>(ForwardIterator,ForwardIterator)' being compiled [D:\Users\shamals\Documents\code\node\tools\v8_gypfiles\v8_compiler.vcxproj]
          with
          [
              ForwardIterator=std::reverse_iterator<v8::internal::compiler::turboshaft::Graph::OperationIterator<const v8::internal::compiler::turboshaft::Operation,const v8::internal::compiler::turboshaft::Graph>>
          ]
D:\Users\shamals\Documents\code\node\deps\v8\src\compiler\turboshaft\decompression-optimization.cc(60): message : see reference to function template instantiation 'auto v8::base::Reversed<v8::internal::compiler::turboshaft::Graph::ConstOperationIte
rator>(const v8::base::iterator_range<v8::internal::compiler::turboshaft::Graph::ConstOperationIterator> &)' being compiled [D:\Users\shamals\Documents\code\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\Users\shamals\Documents\code\node\deps\v8\src\compiler\turboshaft\decompression-optimization.cc(43): message : see reference to function template instantiation 'void v8::internal::compiler::turboshaft::`anonymous-namespace'::DecompressionAnalyze
r::ProcessBlock<true>(const v8::internal::compiler::turboshaft::Block &,uint32_t *)' being compiled [D:\Users\shamals\Documents\code\node\tools\v8_gypfiles\v8_compiler.vcxproj]

[bnoordhuis]

This has either been fixed or it's caused by that specific version of msvc because v19 is building properly on the CI.

Relatedly, there are near-future plans to move from msvc to clang-cl because the former is an unending source of headaches, see #45118.

[StefanStojanovic]

@ssrdive can you provide a commit you were building and possibly a command used for building so I can try to reproduce it? I do not recall seeing this error previously.