Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js API v18.x does not mark 18 LTS but does mark 12 LTS #45316

Open
arhart opened this issue Nov 4, 2022 · 2 comments
Open

Node.js API v18.x does not mark 18 LTS but does mark 12 LTS #45316

arhart opened this issue Nov 4, 2022 · 2 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@arhart
Copy link
Contributor

arhart commented Nov 4, 2022

Affected URL(s)

https://nodejs.org/docs/latest-v18.x/api/index.html

Description of the problem

Under "Other versions", "18.x" is not "18.x LTS" but should be.
"12.x LTS" should be just "12.x".

Currently the header shows v18.12.0. Once it's updated to v18.12.1, it'll be interesting to check again and see if the issue resolves itself (18.12.0 is the first LTS release of the 18.x series).

@arhart arhart added the doc Issues and PRs related to the documentations. label Nov 4, 2022
@arhart
Copy link
Contributor Author

arhart commented Nov 4, 2022

Both components of this issue are resolved now that the header says 18.12.1.

It could be that the documentation is being built before the LTS status is updated. I notice that 12.x was only marked end of life 9 days ago (see #45186), even though support was only planned until 30 April 2022.

Does it make sense to mark a release LTS based solely on date, before the first release after the LTS date? If not, and the build script pulls its information from the changelog, then the build script can't see the LTS status before it's published.

Maybe, rather than applying regular expressions to the changelog, it could source the LTS status from https://github.com/nodejs/Release/blob/main/schedule.json

@aduh95
Copy link
Contributor

aduh95 commented Nov 5, 2022

@nodejs/releasers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

No branches or pull requests

2 participants