Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for large-runners on Github CI #45345

Open
anonrig opened this issue Nov 6, 2022 · 10 comments
Open

Request for large-runners on Github CI #45345

anonrig opened this issue Nov 6, 2022 · 10 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@anonrig
Copy link
Member

anonrig commented Nov 6, 2022

We are currently using Github CI for test-asan.yml, test-linux.yml, text-macos.yml which uses the latest version on all of the workflows. Linux CI machines have 2 cores and macOS machines has 3 cores by default. Latest PR by @Trott shows that using -j3 instead of -j2 on macOS builds reduces the build time by 34 minutes (Referencing: #45340).

There was a pull request open by @targos to use large runner (#44908) but later closed due to the unavailability due to Github internals (Referencing @bnb's comment: #44908 (comment)). @richardlau opened a different pull request for using large runners for test-asan (Referencing #45097), but closed it due to Github's billing system (Referencing: #45097 (comment))

Due to the latest issues with macOS machines (referencing: nodejs/build#2917), I'd like to open an issue to keep track of the process of requesting and getting access to large runners on Github. Even though the issue with the macOS builds is not related to the GitHub machines, it might be good to rely more on Github hosts and less on the Jenkins hosts for macOS, maybe with the possibility of removing them entirely.

Even though I don't know what is the correct spec for the node.js builds, afaik the larger the core size, the faster the builds are done. Therefore I believe that getting access to 64 cores of large runners is appropriate for us. (For the full list: https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners)

cc @nodejs/tsc

@anonrig anonrig added build Issues and PRs related to build files or the CI. tsc-agenda Issues and PRs to discuss during the meetings of the TSC. labels Nov 6, 2022
@mhdawson
Copy link
Member

mhdawson commented Nov 8, 2022

@anonrig the challenge with using GitHub runners in general is that they don't always support the OS versions we need or promise the stability needed to continue to support older Node.js versions. We would need to convince ourselves that for MacOS this is not the case.

@anonrig
Copy link
Member Author

anonrig commented Nov 8, 2022

@mhdawson Replacing existing GitHub workflow runners with large ones will also be beneficial for contributors.

@bnb
Copy link
Contributor

bnb commented Nov 8, 2022

FWIW status from me reaching out to GitHub is the same. I can follow up again soon here, but AFAIK they'll need to do some engineering to allow servers to run on accounts with zero balance.

@richardlau
Copy link
Member

We discussed this in today's Build WG meeting (nodejs/build#3299) but GitHub runners are not really anything the Build WG can help with. I've removed the build-agenda label.

Usage of large runners is linked to what is available on our organization in GitHub, which is managed by the TSC. I presume #45345 (comment) remains a blocker.

@anonrig
Copy link
Member Author

anonrig commented Apr 11, 2023

@mhdawson What are the next steps? What do you recommend?

@mhdawson
Copy link
Member

@anonrig given what @bnb said about Github not being able to give us large runners due to due our zero billing I don't have a suggestion.

My comment was that due to the requirements of our build GitHub is not going to be suitable our need to build/test on specific OS versions.

It might be better if you track "achieve goal" X which larger runners being one option for that.

@anonrig
Copy link
Member Author

anonrig commented Oct 11, 2023

Can we escalate this to OpenJS Foundation CPC? @mhdawson @Trott

@mhdawson
Copy link
Member

@MylesBorins would you have a contact that it would make sense to talk to this about?

@Trott
Copy link
Member

Trott commented Oct 18, 2023

@rginn We're trying to figure out how we might get access to GitHub's larger runners for actions. Is this something the Foundation can help with? Should I bring it to the CPC? Both? Neither?

@MylesBorins
Copy link
Member

I'm chasing this down internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

No branches or pull requests

6 participants