Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unqualified call to std::move in node_http2.cc #45543

Closed
targos opened this issue Nov 20, 2022 · 2 comments · Fixed by #45555
Closed

Unqualified call to std::move in node_http2.cc #45543

targos opened this issue Nov 20, 2022 · 2 comments · Fixed by #45555
Labels
build Issues and PRs related to build files or the CI.

Comments

@targos
Copy link
Member

targos commented Nov 20, 2022

Warning (from clang-cl on Windows) that I don't know how to fix:

src\node_http2.cc(647,32): warning : unqualified call to 'std::move' [-Wunqualified-std-cast-call] [D:\Git\nodejs\node\libnode.vcxproj]

node/src/node_http2.cc

Lines 647 to 650 in 4bee69a

env()->SetImmediate([entry = move(entry)](Environment* env) {
if (HasHttp2Observer(env))
entry->Notify(env);
});

@targos targos added the build Issues and PRs related to build files or the CI. label Nov 20, 2022
@bnoordhuis
Copy link
Member

Just write as entry = std::move(entry)? Or doesn't that fix it?

@targos targos mentioned this issue Nov 21, 2022
Merged
targos added a commit to targos/node that referenced this issue Nov 21, 2022
@targos
src: use qualified std::move call in node_http2
3107b85 
Also iwyu in that file.

Closes: nodejs#45543
@targos
Copy link
Member Author

targos commented Nov 21, 2022

Probably, thanks. #45555

nodejs-github-bot pushed a commit that referenced this issue Nov 23, 2022
@targos
src: use qualified std::move call in node_http2
2a7635f 
Also iwyu in that file.

Closes: #45543
PR-URL: #45555
Fixes: #45543
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this issue Nov 23, 2022
@targos @marco-ippolito
src: use qualified std::move call in node_http2
f962e46 
Also iwyu in that file.

Closes: nodejs#45543
PR-URL: nodejs#45555
Fixes: nodejs#45543
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
ruyadorno pushed a commit that referenced this issue Nov 24, 2022
@targos @ruyadorno
src: use qualified std::move call in node_http2
128c9f6 
Also iwyu in that file.

Closes: #45543
PR-URL: #45555
Fixes: #45543
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@targos @danielleadams
src: use qualified std::move call in node_http2
acdd037 
Also iwyu in that file.

Closes: #45543
PR-URL: #45555
Fixes: #45543
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@targos @danielleadams
src: use qualified std::move call in node_http2
96b3600 
Also iwyu in that file.

Closes: #45543
PR-URL: #45555
Fixes: #45543
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
danielleadams pushed a commit that referenced this issue Jan 3, 2023
@targos @danielleadams
src: use qualified std::move call in node_http2
3f6f8f9 
Also iwyu in that file.

Closes: #45543
PR-URL: #45555
Fixes: #45543
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
danielleadams pushed a commit that referenced this issue Jan 4, 2023
@targos @danielleadams
src: use qualified std::move call in node_http2
14358a2 
Also iwyu in that file.

Closes: #45543
PR-URL: #45555
Fixes: #45543
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
danielleadams pushed a commit that referenced this issue Jan 5, 2023
@targos @danielleadams
src: use qualified std::move call in node_http2
16c650d 
Also iwyu in that file.

Closes: #45543
PR-URL: #45555
Fixes: #45543
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@jameslamb jameslamb mentioned this issue Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: use qualified std::move call in node_http2 targos/node
2 participants
@bnoordhuis @targos