Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect time zone offset for Pacific/Fiji #45598

Closed
felamaslen opened this issue Nov 23, 2022 · 5 comments
Closed

Incorrect time zone offset for Pacific/Fiji #45598

felamaslen opened this issue Nov 23, 2022 · 5 comments

Comments

@felamaslen
Copy link

felamaslen commented Nov 23, 2022

Version

v16.13.2 (also applies in v19.1.0)

Platform

Linux myhostname 6.0.8-arch1-1 #1 SMP PREEMPT_DYNAMIC Thu, 10 Nov 2022 21:14:24 +0000 x86_64 GNU/Linux

Subsystem

Intl API / ICU

What steps will reproduce the bug?

console.log(Intl.DateTimeFormat('en', { hour: 'numeric', minute: 'numeric', timeZone: 'Pacific/Fiji', timeZoneName: 'long' }).format(new Date('2022-11-18T00:00:00Z')))

How often does it reproduce? Is there a required condition?

100% of the time.

What is the expected behavior?

Outputs 12:00 PM Fiji Standard Time

What do you see instead?

Outputs 1:00 PM Fiji Summer Time

Additional information

Fiji cancelled DST in 2022: https://www.timeanddate.com/news/time/fiji-no-dst-2022-2023.html

Node.JS still thinks that Fiji uses DST in 2022.

@felamaslen
Copy link
Author

My system's time and date works fine:

$ TZ=Pacific/Fiji date
Thu 24 Nov 00:11:55 +12 2022

@mscdex
Copy link
Contributor

mscdex commented Nov 23, 2022

This was already fixed with the ICU timezone data update 2022f here, which was only merged 7 days ago, so it hasn't had a chance to make its way into any releases yet.

@felamaslen
Copy link
Author

I can still reproduce this issue in v16.18.1 and v18.12.1. The only release I can see that it has been fixed on is v19.2.0.

@mscdex
Copy link
Contributor

mscdex commented Dec 6, 2022

Right, it has to be backported to those branches first, like most other (non-semver major) commits. As of this moment, backported commits have only landed for v14.x. See also the v16.x backport (which will be the basis for the v18.x backport apparently).

@richardlau
Copy link
Member

v18.x-staging landed the ICU update so the timezone update from main has been cherry-picked onto it.
I've volunteered to do the next 14 and 16 releases -- current plan (nodejs/Release#658, nodejs/Release#567) is targetting next week.

If you need the updated timezone information before the Node.js releases are ready, I documented a workaround in nodejs/Release#773 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants