Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate ESM before npm publish #46081

Closed
brillout opened this issue Jan 3, 2023 · 2 comments
Closed

Validate ESM before npm publish #46081

brillout opened this issue Jan 3, 2023 · 2 comments
Labels
feature request Issues that request new features to be added to Node.js. npm Issues and PRs related to the npm client dependency or the npm registry. wrong repo Issues that should be opened in another repository.

Comments

@brillout
Copy link
Contributor

brillout commented Jan 3, 2023

What is the problem this feature will solve?

Many npm packages contain invalid ESM, which makes Node.js choke.

The situation is quite bad, as described in #46074.

What is the feature you are proposing to solve the problem?

Validate the npm package before it's being published: npm should reject any npm publish that publishes invalid ESM.

For reference, https://publint.dev is a project that validates whether an npm package is published correctly.

What alternatives have you considered?

No response
@brillout brillout added the feature request Issues that request new features to be added to Node.js. label Jan 3, 2023
@brillout brillout mentioned this issue Jan 3, 2023
Closed
@bnoordhuis
Copy link
Member

Thanks for the suggestion but you'll have to take this up with the npm people. Node bundles npm but doesn't maintain it.

@bnoordhuis bnoordhuis closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2023
@bnoordhuis bnoordhuis added npm Issues and PRs related to the npm client dependency or the npm registry. wrong repo Issues that should be opened in another repository. labels Jan 3, 2023
@brillout
Copy link
Contributor Author

brillout commented Jan 3, 2023

Done: npm/rfcs#665.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. npm Issues and PRs related to the npm client dependency or the npm registry. wrong repo Issues that should be opened in another repository.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bnoordhuis @brillout