Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Corepack 0.17.0 to Node.js 18 LTS #46937

Closed
denexapp opened this issue Mar 3, 2023 · 2 comments
Closed

Backport Corepack 0.17.0 to Node.js 18 LTS #46937

denexapp opened this issue Mar 3, 2023 · 2 comments
Labels
feature request Issues that request new features to be added to Node.js.

Comments

@denexapp
Copy link

denexapp commented Mar 3, 2023

What is the problem this feature will solve?

The latest LTS version of Node.js uses Corepack v0.15.3 (link). This version of corepack has an issue that prevents corepack to use custom registries to download package managers.

I hit this issue. I can not access default npm registry because it's blocked by corporate firewall, and I can not use custom registry because of the bug of corepack

What is the feature you are proposing to solve the problem?

This issue was fixed in the latest versions of Corepack in this PR.

Merge requests were created to use the latest 0.17.0 version of Corepack for Node.js v19, v16 and v14.

But there's no merge request for Node.js v18.

I think Corepack v0.17.0 should be backported to Node.js v18 as well.

Tagging @aduh95 as the author of these PR's, what do you think? I can make a similar PR if it's needed.

What alternatives have you considered?

The alternative is to update Corepack to the latest version after the installation of Node.js v18 manually using npm install -g corepack.

While this workaround solves the problem, I think it's better to address this problem at the level of Node.js itself, so users won't face the problem at all.

@denexapp denexapp added the feature request Issues that request new features to be added to Node.js. label Mar 3, 2023
@aduh95
Copy link
Contributor

aduh95 commented Mar 3, 2023

Node.js 18.x is an Active LTS release line, meaning every1 commit that lands on a Current release line would get backported "automatically"2 after a maturation period (which is typically not less than 2 weeks, but is at the discretion of the releaser). I've opened backport PR for v16.x and v14.x because those Maintenance LTS, not Active LTS. There's no PR for v18.x because it's not necessary, and would give more work to the release team.

Footnotes

  1. unless the PR it's from has been tagged as unsuited for LTS

  2. "automatically" here actually means "manually by the releaser", but that doesn't generate any visible activity on GitHub unless the commit doesn't land cleanly on the staging branch, in which case the releaser would add a comment to the PR the commit is from.

@aduh95 aduh95 closed this as completed Mar 3, 2023
@denexapp
Copy link
Author

denexapp commented Mar 3, 2023

Thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js.
Projects
None yet
Development

No branches or pull requests

2 participants