Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation of process.versions should be updated #48016

Closed
targos opened this issue May 15, 2023 · 5 comments · Fixed by #48019
Closed

Documentation of process.versions should be updated #48016

targos opened this issue May 15, 2023 · 5 comments · Fixed by #48019
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@targos
Copy link
Member

targos commented May 15, 2023

Affected URL(s)

https://github.com/nodejs/node/blob/main/doc/api/process.md#processversions

Description of the problem

It's missing at least the properties added in #45629
@targos targos added the doc Issues and PRs related to the documentations. label May 15, 2023
@RaisinTen RaisinTen added the good first issue Issues that are suitable for first-time contributors. label May 15, 2023
@Basa198
Copy link
Contributor

Basa198 commented May 15, 2023

Hello, I am new to OS contributions, can I take this?

@RaisinTen
Copy link
Contributor

For anyone who's interested, please feel free to open a PR directly. No need to ask for permissions or anything. :)

@Basa198
Copy link
Contributor

Basa198 commented May 15, 2023

Okay, I am on it then.

@Basa198 Basa198 mentioned this issue May 15, 2023
Merged
Basa198 added a commit to Basa198/node that referenced this issue May 15, 2023
@Basa198
doc: updated process.versions properties
8af951a 
Fixes: nodejs#48016
Basa198 added a commit to Basa198/node that referenced this issue May 15, 2023
@Basa198
doc: update process.versions properties
8a1a5c5 
Fixes: nodejs#48016
@amul69906995 amul69906995 mentioned this issue May 15, 2023
Closed
@amul69906995
Copy link

@RaisinTen i have made a pr

@amul69906995
Copy link

this is my first contribution i think i have made changes correctly by adding the new properties in process.version

xvisierra added a commit to xvisierra/node that referenced this issue May 16, 2023
@xvisierra
issue nodejs#48016 process.versions updated
d9a73cf
nodejs-github-bot pushed a commit that referenced this issue May 17, 2023
@Basa198
doc: update process.versions properties
1fdcb1c 
Fixes: #48016
PR-URL: #48019
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue May 30, 2023
@Basa198 @targos
doc: update process.versions properties
85bbaa9 
Fixes: #48016
PR-URL: #48019
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: updated process.versions properties Basa198/node
4 participants
@targos @RaisinTen @amul69906995 @Basa198