Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel/test-tls-socket-close is flaky #49628

Closed
joyeecheung opened this issue Sep 12, 2023 · 2 comments · Fixed by #49575
Closed

parallel/test-tls-socket-close is flaky #49628

joyeecheung opened this issue Sep 12, 2023 · 2 comments · Fixed by #49575
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@joyeecheung
Copy link
Member

From nodejs/reliability#663

Reason parallel/test-tls-socket-close
Type JS_TEST_FAILURE
Failed PR 5 (#49279, #49567, #49532, #49144, #49543)
Appeared test-ibm-rhel8-s390x-2, test-ibm-rhel8-s390x-4, test-nearform-macos11.0-arm64-1, test-digitalocean-ubi81_container-x64-1
First CI https://ci.nodejs.org/job/node-test-pull-request/53815/
Last CI https://ci.nodejs.org/job/node-test-pull-request/53887/
Example
not ok 2873 parallel/test-tls-socket-close
  ---
  duration_ms: 424.85800
  severity: fail
  exitcode: 1
  stack: |-
    node:assert:125
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    
    false !== true
    
        at Immediate._onImmediate (/home/iojs/build/workspace/node-test-commit-linuxone/test/parallel/test-tls-socket-close.js:47:16)
        at process.processImmediate (node:internal/timers:478:21) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: false,
      expected: true,
      operator: 'strictEqual'
    }
    
    Node.js v21.0.0-pre
  ...

It seems it started flaking since Sep 8, see nodejs/reliability#659

@joyeecheung
Copy link
Member Author

cc @nodejs/net @nodejs/crypto

@joyeecheung
Copy link
Member Author

Looks like there is a PR fixing it #49575 (somehow my initial search in the issue tracker did not lead me to that PR, only found out about it via git blame in the test)

@joyeecheung joyeecheung added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Sep 12, 2023
@targos targos linked a pull request Sep 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant