Add tests for filenames with surrogate pairs on Windows

[AlttiRi]

What is the problem this feature will solve?

• (Windows) FS can not handle certain characters in file name #48673

That issue is still not fixed in LTS. There are no guarantees that the bug will not appear in Current again.

What is the feature you are proposing to solve the problem?

Just add tests for fs functions that will work with names contain surrogate pairs (emoji, but not only):

import fs from "node:fs/promises";

await fs.writeFile("🚀🔥🛸.txt", "");
await fs.lstat("🚀🔥🛸.txt");

Don't release Node.js while they fail.

What alternatives have you considered?

Something like this:
https://github.com/oven-sh/bun/blob/3221bfeeb7036e76872c1a602aa5cd7c83ed3b4a/test/js/node/fs/fs.test.ts#L681-L701

[mertcanaltin]

I think a file name with emojis will not be healthy in development processes

[AlttiRi]

Node.js is only for the "development process" now?

What is the "development process"? And why while this "development process" I can't access the files with the legal filenames?

Node.js must not be used for desktop (Electron, NW and console) applications?

---

There is a file system bug on Windows.
Fix it and add tests to prevent it from regression in future.
If there were tests, then the breaking regression bug #48673 would not have appeared, which has not been fixed in LTS yet.

[anonrig]

Any PRs are welcome

[mertcanaltin]

Node.js is only for the "development process" now?

What is the "development process"? And why while this "development process" I can't access the files with the legal filenames?

Node.js must not be used for desktop (Electron, NW and console) applications?

There is a file system bug on Windows.
Fix it and add tests to prevent it from regression in future.
If there were tests, then the breaking regression bug #48673 would not have appeared, which has not been fixed in LTS yet.

I understand better now, sorry, I thought it was just a name feature with emojis.

[mertcanaltin]

I'll be opening a pr trying to solve this

[mertcanaltin]

I created a test for it and everything looks good
If there is something missing or something you would like to see improved, please do not hesitate

[AlttiRi]

Yeah, the test fails on 20.11.1 LTS and passes on 21.6.2 Current as expected.

---

UPD.

node-v20.11.1-x64.msi:

node-v21.6.2-x64.msi:

[mertcanaltin]

I ran my test in the version you said and there was no problem. @AlttiRi

v20.11.1
➜  node git:(dev-51789) node test/common/file-ops-with-surrogate-pairs-on-windows.js
▶ File operations with filenames containing surrogate pairs on Windows
  ✔ should write, read, and delete a file with surrogate pairs in the filename (19.227042ms)
▶ File operations with filenames containing surrogate pairs on Windows (20.333584ms)

ℹ tests 1
ℹ suites 1
ℹ pass 1
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 25.379917
➜  node git:(dev-51789) ```

[anonrig]

cc @nodejs/platform-windows

[AlttiRi]

Was this test backported to 20.x?
Was the bug fixed on 20.x?

[richardlau]

Was this test backported to 20.x? Was the bug fixed on 20.x?

#51976