From 64571fa73d7cda2f34cb7f97ad112cac38945b40 Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Thu, 28 Dec 2017 18:58:08 +0100 Subject: [PATCH] assert: fix strict regression Using `assert()` or `assert.ok()` resulted in a error since a refactoring. Refs: https://github.com/nodejs/node/pull/17582 --- lib/assert.js | 10 +++++++++- test/parallel/test-assert.js | 8 ++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/lib/assert.js b/lib/assert.js index c4f73f40071d9b..57d45ed2eba541 100644 --- a/lib/assert.js +++ b/lib/assert.js @@ -316,7 +316,15 @@ assert.ifError = function ifError(err) { if (err) throw err; }; // Expose a strict only variant of assert function strict(value, message) { - if (!value) innerFail(value, true, message, '==', strict); + if (!value) { + innerFail({ + actual: value, + expected: true, + message, + operator: '==', + stackStartFn: strict + }); + } } assert.strict = Object.assign(strict, assert, { equal: assert.strictEqual, diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js index c7bbd9249da387..862bccaacc7124 100644 --- a/test/parallel/test-assert.js +++ b/test/parallel/test-assert.js @@ -753,6 +753,14 @@ common.expectsError( assert.equal(Object.keys(assert).length, Object.keys(a).length); /* eslint-enable no-restricted-properties */ assert(7); + common.expectsError( + () => assert(), + { + code: 'ERR_ASSERTION', + type: assert.AssertionError, + message: 'undefined == true' + } + ); } common.expectsError(