Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add types for some process properties #19571

Closed
wants to merge 1 commit into from
Closed

doc: add types for some process properties #19571

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Mar 24, 2018 •
edited

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sync types:

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 24, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Mar 24, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Mar 24, 2018 •
edited

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/309/

@vsemozhetbyt
Copy link
Contributor Author

Landed in d59e249

vsemozhetbyt added a commit that referenced this pull request Mar 24, 2018
@vsemozhetbyt
doc: add types for some process properties
d59e249 
PR-URL: #19571
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@vsemozhetbyt vsemozhetbyt deleted the doc-process-types branch March 24, 2018 14:55
targos pushed a commit that referenced this pull request Mar 27, 2018
@vsemozhetbyt @targos
doc: add types for some process properties
933c58c 
PR-URL: #19571
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 3, 2018
@vsemozhetbyt @BethGriggs
doc: add types for some process properties
63d8632 
PR-URL: #19571
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vsemozhetbyt @jasnell @lpinca @nodejs-github-bot