From 1f02e582240110924a872c6dad2d94420d2fc37c Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Wed, 26 Dec 2018 13:21:57 +0100 Subject: [PATCH] test: fix test-repl-envvars In 180f86507d496b11aa35b2df4594629a92cce329, the test was changed so that the `env` argument of `createInternalRepl()` also contained external environment variables, because keeping them can be necessary for spawning processes on some systems. However, this test does not spawn new processes, and relies on the fact that the environment variables it tests are not already set (and fails otherwise); therefore, reverting to the original state should fix this. Fixes: https://github.com/nodejs/node/issues/21451 Fixes: https://github.com/nodejs/build/issues/1377 Refs: https://github.com/nodejs/node/pull/25219 --- test/parallel/test-repl-envvars.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-repl-envvars.js b/test/parallel/test-repl-envvars.js index 5606efc26ed031..6679cd6cd73a31 100644 --- a/test/parallel/test-repl-envvars.js +++ b/test/parallel/test-repl-envvars.js @@ -36,7 +36,7 @@ const tests = [ ]; function run(test) { - const env = Object.assign({}, process.env, test.env); + const env = test.env; const expected = test.expected; const opts = { terminal: true,