Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centos7 ppc64 le v8 test support #28458

Closed
wants to merge 2 commits into from
Closed

Centos7 ppc64 le v8 test support #28458

wants to merge 2 commits into from

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Jun 27, 2019 •
edited

one:

tools: move python code out of jenkins shell

https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

two:

tools: fix v8 testing with devtoolset on ppcle

The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Jun 27, 2019
@sam-github sam-github mentioned this pull request Jun 27, 2019
Closed
@sam-github
tools: fix v8 testing with devtoolset on ppcle
28974ee 
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.
@sam-github
tools: move python code out of jenkins shell
c3db2ca 
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.
@sam-github sam-github force-pushed the centos7-ppc64-le-v8-test-support branch from 1166b09 to c3db2ca Compare June 27, 2019 22:29
@sam-github sam-github marked this pull request as ready for review June 28, 2019 15:02
@sam-github
Copy link
Contributor Author

sam-github commented Jun 28, 2019 •
edited

centos7-ppcle passed in: https://ci.nodejs.org/job/node-test-commit-v8-linux/2396/nodes=centos7-ppcle,v8test=v8test/console

repeat the builds:

lite ci: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3726/ PASS

v8 ci: https://ci.nodejs.org/job/node-test-commit-v8-linux/2399/ PASS

@richardlau
Copy link
Member

Are the three new Python scripts meant to be called from an existing Python/shell script?

@sam-github
Copy link
Contributor Author

@richardlau Sorry, pulled the commit message details into the description. I wish github did that for me on multi-commit PRs.

mhdawson
mhdawson approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-github
Copy link
Contributor Author

Can I fast-track this, @nodejs/build @targos ?

@mhdawson
Copy link
Member

+1 to fast track from me

@mhdawson mhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 28, 2019
@danbev
Copy link
Contributor

danbev commented Jul 2, 2019

Landed in e669b81, and ed14aa6.

@danbev danbev closed this Jul 2, 2019
danbev pushed a commit that referenced this pull request Jul 2, 2019
@sam-github @danbev
tools: fix v8 testing with devtoolset on ppcle
e669b81 
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danbev pushed a commit that referenced this pull request Jul 2, 2019
@sam-github @danbev
tools: move python code out of jenkins shell
ed14aa6 
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@sam-github @targos
tools: fix v8 testing with devtoolset on ppcle
47046cf 
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@sam-github @targos
tools: move python code out of jenkins shell
c41c6ce 
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@sam-github @targos
tools: fix v8 testing with devtoolset on ppcle
d38b985 
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@sam-github @targos
tools: move python code out of jenkins shell
40ae2a6 
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
@cclauss cclauss added the python PRs and issues that require attention from people who are familiar with Python. label Jul 20, 2019
@sam-github sam-github deleted the centos7-ppc64-le-v8-test-support branch July 23, 2019 19:43
@richardlau richardlau mentioned this pull request Nov 12, 2019
Closed
BethGriggs pushed a commit that referenced this pull request Nov 19, 2019
@sam-github @BethGriggs
tools: fix v8 testing with devtoolset on ppcle
7066335 
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Nov 19, 2019
@sam-github @BethGriggs
tools: move python code out of jenkins shell
7ff19be 
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@sam-github @MylesBorins
tools: fix v8 testing with devtoolset on ppcle
4879b80 
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them
if not present.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@sam-github @MylesBorins
tools: move python code out of jenkins shell
4ae8d20 
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes
python code into tools and runs it. Move these scripts into tools for
better maintainability.

Once this lands and is back-ported into LTS branches a bunch of shell
code can be deleted from the job.

PR-URL: #28458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Jan 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sam-github @richardlau @mhdawson @danbev @Trott @cclauss @BethGriggs @nodejs-github-bot