Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update outdated ESM/CommonJS compatibility info #30512

Conversation

GeoffreyBooth
Copy link
Member

Some of the text in the Interoperability with CommonJS section was out of date and no longer correct.

Checklist

cc @nodejs/modules-active-members

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 17, 2019
Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Member

Can we please fast-track

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 17, 2019
@MylesBorins
Copy link
Member

Landed in 5c57616

MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
PR-URL: #30512
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
PR-URL: #30512
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ljharb ljharb deleted the fix-commonjs-compatibility-info branch November 18, 2019 23:29
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
PR-URL: #30512
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #30512
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants