From 8c3147bb8d127b2a979a16d2239e823df1371cdb Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Fri, 6 Dec 2019 01:09:09 +0100 Subject: [PATCH] lib: further simplify assertions in vm/module Refs: https://github.com/nodejs/node/pull/30755 --- lib/internal/vm/module.js | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/lib/internal/vm/module.js b/lib/internal/vm/module.js index ee2fec2e431380..37a383a50d9e96 100644 --- a/lib/internal/vm/module.js +++ b/lib/internal/vm/module.js @@ -1,6 +1,6 @@ 'use strict'; -const { fail } = require('internal/assert'); +const assert = require('internal/assert'); const { ArrayIsArray, ObjectCreate, @@ -59,11 +59,6 @@ const kContext = Symbol('kContext'); const kPerContextModuleId = Symbol('kPerContextModuleId'); const kLink = Symbol('kLink'); -function failIfDebug() { - if (process.features.debug === false) return; - fail('VM Modules'); -} - class Module { constructor(options) { emitExperimentalWarning('VM Modules'); @@ -119,12 +114,11 @@ class Module { importModuleDynamicallyWrap(options.importModuleDynamically) : undefined, }); - } else if (syntheticEvaluationSteps) { + } else { + assert(syntheticEvaluationSteps); this[kWrap] = new ModuleWrap(identifier, context, syntheticExportNames, syntheticEvaluationSteps); - } else { - failIfDebug(); } wrapToModuleMap.set(this[kWrap], this); @@ -380,7 +374,9 @@ class SyntheticModule extends Module { identifier, }); - this[kLink] = () => this[kWrap].link(() => { failIfDebug(); }); + this[kLink] = () => this[kWrap].link(() => { + assert.fail('link callback should not be called'); + }); } setExport(name, value) {