Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: unregister temporary error listener #30852

Closed
wants to merge 1 commit into from
Closed

console: unregister temporary error listener #30852

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Dec 8, 2019

I think the idea here was to swallow ONE error. Not sure if this actually makes any difference. Can the stream be re-used after having errored?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the console Issues and PRs related to the console subsystem. label Dec 8, 2019
@Trott
Copy link
Member

Trott commented Dec 8, 2019

Is it worthwhile to write a test for this?

@Trott
Copy link
Member

Trott commented Dec 8, 2019

@nodejs/console

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27652/

@Trott
Copy link
Member

Trott commented Dec 14, 2019

Landed in d64c1dc

@Trott Trott closed this Dec 14, 2019
Trott pushed a commit that referenced this pull request Dec 14, 2019
@ronag @Trott
console: unregister temporary error listener
d64c1dc 
PR-URL: #30852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@ronag @MylesBorins
console: unregister temporary error listener
4f3eca5 
PR-URL: #30852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@ronag @targos
console: unregister temporary error listener
17fc4b0 
PR-URL: #30852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@ronag @BethGriggs
console: unregister temporary error listener
f54dc36 
PR-URL: #30852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
This was referenced Apr 13, 2021
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 17, 2021
Open
Open
Open
Open
This was referenced Sep 18, 2021
Open
Open
Open
@Dmarch28 Dmarch28 mentioned this pull request May 13, 2022
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 13, 2022
Open
@137717unity 137717unity mentioned this pull request May 13, 2022
Open
@baby636 baby636 mentioned this pull request May 13, 2022
Open
@kissofire kissofire mentioned this pull request May 13, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 13, 2022
Open
@ron-a20 ron-a20 mentioned this pull request May 13, 2022
Open
@molllyn1 molllyn1 mentioned this pull request May 14, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 25, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 28, 2023
Open
@baby636 baby636 mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. console Issues and PRs related to the console subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ronag @Trott @nodejs-github-bot @addaleax