[v12.x] deps: V8: backport postmortem metadata fixes #30870

mmarchini · 2019-12-09T22:27:02Z

V8 7.7 branch is closed, I tried backporting these commits upstream but it was not approved. These commits are necessary for llnode to work with Node.js v12.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

mhdawson

LGTM

nodejs-github-bot · 2019-12-09T23:09:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27531/

targos · 2019-12-10T00:05:14Z

deps/v8/BUILD.gn

@@ -870,6 +870,8 @@ action("postmortem-metadata") {
    "src/objects/code.h",
    "src/objects/data-handler.h",
    "src/objects/data-handler-inl.h",
+    "src/objects/descriptor-array.h",
+    "src/objects/descriptor-array-inl.h",


don't we need the same change in v8.gyp?

I thought so, but it worked on my machine when I built it (metadata was correct in the final binary). I also couldn't find where to change on V8.gyp when I searched using grep. I think we're inferring this parameter from BUILD.gn now?

Oh yes I'm sorry, it must be one of the lists that are scraped automatically from build.gn

nodejs-github-bot · 2019-12-12T19:26:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27590/

nodejs-github-bot · 2019-12-12T20:49:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27593/

mmarchini · 2019-12-12T21:23:40Z

SmartOS failure is legit. I'll send a commit to fix it.

nodejs-github-bot · 2019-12-27T18:57:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27982/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2742/

mmarchini · 2019-12-27T19:03:20Z

Reverted 59b4640 and f056d55, since string metadata name changes were reverted in v8/v8@b38dfaf3a633. cc @cjihrig

nodejs-github-bot · 2019-12-27T23:36:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27988/

mmarchini · 2020-01-02T19:59:24Z

Should I land this or should I wait for someone from @nodejs/releasers to do it? I couldn't find this information on https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md or https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md

Original commit message: [postmortem] add metadata for the new DescriptorArray layout R=yangguo@chromium.org Ref: nodejs/llnode#255 Change-Id: Icda271123375db5c381fe1d1bba13dcc26f26d7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832311 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#64169} Refs: v8/v8@cc5016e

Original commit message: [postmortem] update Symbol and *String metadata Symbol and *String classes are now declared on Torque with generateCppClass, which means they don't use macro accessors anymore. As such, the gen-postmortem-metadata script is not able to automatically detect fields for those classes. Define metadata for those fields manually for now. In the future we might want to generate it from Torque for consistency. Also renamed a few *String fields metadata to match the expected format (className__fieldName__fieldType). For more context: nodejs/llnode#287 (comment). R=bmeurer@chromium.org, hpayer@chromium.org, verwaest@chromium.org, yangguo@chromium.org Change-Id: I82fe8315cdbfd1b8c64c6a8d5dc011b1edaec39e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847783 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#64313} Refs: v8/v8@b38dfaf

This reverts commit 59b4640.

This reverts commit f056d55.

nodejs-github-bot · 2020-01-08T01:02:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28280/
https://ci.nodejs.org/job/node-test-commit-v8-linux/2773/

MylesBorins · 2020-01-08T01:03:33Z

@mmarchini for LTS lines it should be left to backporters to land. I've gone ahead and rebase the PR against the 12.x-staging branch as we just updated to 7.8

mmarchini · 2020-01-13T19:01:17Z

@MylesBorins there is a small conflict on common.gypi, do you mind if I rebase to fix it, or do you want to do it?

MylesBorins · 2020-01-14T01:02:04Z

Go for it!

…

On Mon, Jan 13, 2020, 2:01 PM Matheus Marchini ***@***.***> wrote: @MylesBorins <https://github.com/MylesBorins> there is a small conflict on common.gypi, do you mind if I rebase to fix it, or do you want to do it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30870?email_source=notifications&email_token=AADZYV4LMPAIWKWWHEKUD7DQ5S3ABA5CNFSM4JYTT2Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZ4J7Y#issuecomment-573818111>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADZYV4VNBL5LLP2QZMVBWDQ5S3ABANCNFSM4JYTT2QQ> .

Original commit message: [postmortem] add metadata for the new DescriptorArray layout R=yangguo@chromium.org Ref: nodejs/llnode#255 Change-Id: Icda271123375db5c381fe1d1bba13dcc26f26d7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832311 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#64169} Refs: v8/v8@cc5016e PR-URL: #30870 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Original commit message: [postmortem] update Symbol and *String metadata Symbol and *String classes are now declared on Torque with generateCppClass, which means they don't use macro accessors anymore. As such, the gen-postmortem-metadata script is not able to automatically detect fields for those classes. Define metadata for those fields manually for now. In the future we might want to generate it from Torque for consistency. Also renamed a few *String fields metadata to match the expected format (className__fieldName__fieldType). For more context: nodejs/llnode#287 (comment). R=bmeurer@chromium.org, hpayer@chromium.org, verwaest@chromium.org, yangguo@chromium.org Change-Id: I82fe8315cdbfd1b8c64c6a8d5dc011b1edaec39e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847783 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#64313} Refs: v8/v8@b38dfaf PR-URL: #30870 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

This reverts commit 59b4640. PR-URL: #30870 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

This reverts commit f056d55. PR-URL: #30870 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

targos · 2020-01-14T08:02:00Z

Went ahead and landed this in 8c5e951, 015671d, 6bc2ce2, and 4fd4a73. Thanks for the PR!

Original commit message: [postmortem] add metadata for the new DescriptorArray layout R=yangguo@chromium.org Ref: nodejs/llnode#255 Change-Id: Icda271123375db5c381fe1d1bba13dcc26f26d7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832311 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#64169} Refs: v8/v8@cc5016e PR-URL: #30870 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Original commit message: [postmortem] update Symbol and *String metadata Symbol and *String classes are now declared on Torque with generateCppClass, which means they don't use macro accessors anymore. As such, the gen-postmortem-metadata script is not able to automatically detect fields for those classes. Define metadata for those fields manually for now. In the future we might want to generate it from Torque for consistency. Also renamed a few *String fields metadata to match the expected format (className__fieldName__fieldType). For more context: nodejs/llnode#287 (comment). R=bmeurer@chromium.org, hpayer@chromium.org, verwaest@chromium.org, yangguo@chromium.org Change-Id: I82fe8315cdbfd1b8c64c6a8d5dc011b1edaec39e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847783 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#64313} Refs: v8/v8@b38dfaf PR-URL: #30870 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

This reverts commit 59b4640. PR-URL: #30870 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

This reverts commit f056d55. PR-URL: #30870 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. v12.x v8 engine Issues and PRs related to the V8 dependency. labels Dec 9, 2019

mhdawson approved these changes Dec 9, 2019

View reviewed changes

targos reviewed Dec 10, 2019

View reviewed changes

MylesBorins force-pushed the v12.x-staging branch from ac6ff77 to f3c3b1d Compare December 17, 2019 22:07

mmarchini force-pushed the v12.x-backport-postmortem-metadata branch from 0c80610 to 1730fc1 Compare December 27, 2019 18:56

mmarchini added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 27, 2019

BethGriggs force-pushed the v12.x-staging branch from d96c765 to b08601b Compare December 31, 2019 01:00

mmarchini and others added 4 commits January 7, 2020 20:00

Revert "src: update v8abbr.h for V8 7.7"

0a42e03

This reverts commit 59b4640.

Revert "test: update postmortem metadata test for V8 7.7"

15a2ca7

This reverts commit f056d55.

MylesBorins force-pushed the v12.x-backport-postmortem-metadata branch from 1730fc1 to 15a2ca7 Compare January 8, 2020 01:01

targos force-pushed the v12.x-staging branch 2 times, most recently from 3900f4a to 32e5c39 Compare January 8, 2020 16:34

MylesBorins force-pushed the v12.x-staging branch from 10b7951 to 0a4cfef Compare January 12, 2020 09:38

mmarchini mentioned this pull request Jan 13, 2020

llnode don't support nodejs v12 nodejs/llnode#328

Closed

targos pushed a commit that referenced this pull request Jan 14, 2020

Revert "src: update v8abbr.h for V8 7.7"

6bc2ce2

This reverts commit 59b4640. PR-URL: #30870 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

targos pushed a commit that referenced this pull request Jan 14, 2020

Revert "test: update postmortem metadata test for V8 7.7"

4fd4a73

This reverts commit f056d55. PR-URL: #30870 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

targos closed this Jan 14, 2020

targos mentioned this pull request Jan 15, 2020

v12.15.0 release proposal #31368

Closed

BethGriggs pushed a commit that referenced this pull request Feb 6, 2020

Revert "src: update v8abbr.h for V8 7.7"

29608be

This reverts commit 59b4640. PR-URL: #30870 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

BethGriggs pushed a commit that referenced this pull request Feb 6, 2020

Revert "test: update postmortem metadata test for V8 7.7"

023a802

This reverts commit f056d55. PR-URL: #30870 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins mentioned this pull request Feb 8, 2020

v12.16.0 proposal #31691

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v12.x] deps: V8: backport postmortem metadata fixes #30870

[v12.x] deps: V8: backport postmortem metadata fixes #30870

mmarchini commented Dec 9, 2019

mhdawson left a comment

nodejs-github-bot commented Dec 9, 2019

targos Dec 10, 2019

mmarchini Dec 10, 2019

targos Dec 10, 2019

nodejs-github-bot commented Dec 12, 2019

nodejs-github-bot commented Dec 12, 2019

mmarchini commented Dec 12, 2019

nodejs-github-bot commented Dec 27, 2019 •

edited by mmarchini

mmarchini commented Dec 27, 2019

nodejs-github-bot commented Dec 27, 2019

mmarchini commented Jan 2, 2020

nodejs-github-bot commented Jan 8, 2020 •

edited by MylesBorins

MylesBorins commented Jan 8, 2020

mmarchini commented Jan 13, 2020

MylesBorins commented Jan 14, 2020 via email

targos commented Jan 14, 2020

[v12.x] deps: V8: backport postmortem metadata fixes #30870

[v12.x] deps: V8: backport postmortem metadata fixes #30870

Conversation

mmarchini commented Dec 9, 2019

Checklist

mhdawson left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Dec 9, 2019

targos Dec 10, 2019

Choose a reason for hiding this comment

mmarchini Dec 10, 2019

Choose a reason for hiding this comment

targos Dec 10, 2019

Choose a reason for hiding this comment

nodejs-github-bot commented Dec 12, 2019

nodejs-github-bot commented Dec 12, 2019

mmarchini commented Dec 12, 2019

nodejs-github-bot commented Dec 27, 2019 • edited by mmarchini

mmarchini commented Dec 27, 2019

nodejs-github-bot commented Dec 27, 2019

mmarchini commented Jan 2, 2020

nodejs-github-bot commented Jan 8, 2020 • edited by MylesBorins

MylesBorins commented Jan 8, 2020

mmarchini commented Jan 13, 2020

MylesBorins commented Jan 14, 2020 via email

targos commented Jan 14, 2020

nodejs-github-bot commented Dec 27, 2019 •

edited by mmarchini

nodejs-github-bot commented Jan 8, 2020 •

edited by MylesBorins